Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: third_party/WebKit/Source/core/svg/SVGViewSpec.h

Issue 2485113002: Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGViewSpec.h
diff --git a/third_party/WebKit/Source/core/svg/SVGViewSpec.h b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
index 24efc8e47601737562a4afc5b360ca8898372001..47af75f7d5bf2fe71038d467350a63b61727be0f 100644
--- a/third_party/WebKit/Source/core/svg/SVGViewSpec.h
+++ b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
@@ -20,7 +20,6 @@
#ifndef SVGViewSpec_h
#define SVGViewSpec_h
-#include "bindings/core/v8/TraceWrapperMember.h"
#include "core/svg/SVGFitToViewBox.h"
#include "core/svg/SVGSVGElement.h"
#include "core/svg/SVGZoomAndPan.h"
@@ -29,10 +28,8 @@
namespace blink {
class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
- public ScriptWrappable,
public SVGZoomAndPan,
foolip 2016/11/08 09:42:42 Have you verified that both of these still need to
fs 2016/11/08 10:29:40 With the setZoomAndPan overrides below (which thin
Shanmuga Pandi 2016/11/09 06:34:56 though setZoomAndPan overrides, but parseViewSpecI
Shanmuga Pandi 2016/11/09 06:34:56 I have checked. It seems both are needed.
fs 2016/11/09 11:39:53 Acknowledged. But just removing the setZoomAndPan
Shanmuga Pandi 2016/11/09 12:00:06 Not sure. Do you want to remove below two ? void s
fs 2016/11/09 12:13:05 Yes, at the very least the second one. Removing th
Shanmuga Pandi 2016/11/11 12:35:50 Done.
public SVGFitToViewBox {
- DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(SVGViewSpec);
public:
@@ -42,22 +39,12 @@ class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
bool parseViewSpec(const String&);
void reset();
- void detachContextElement();
template <typename T>
void inheritViewAttributesFromElement(T*);
- // JS API
SVGTransformList* transform() {
return m_transform ? m_transform->baseValue() : 0;
}
- SVGTransformListTearOff* transformFromJavascript() {
- return m_transform ? m_transform->baseVal() : 0;
- }
- SVGElement* viewTarget() const;
- String viewBoxString() const;
- String preserveAspectRatioString() const;
- String transformString() const;
- String viewTargetString() const { return m_viewTargetString; }
// override SVGZoomAndPan.setZoomAndPan so can throw exception on write
void setZoomAndPan(unsigned short value) {} // read only
void setZoomAndPan(unsigned short value, ExceptionState&);
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.idl ('k') | third_party/WebKit/Source/core/svg/SVGViewSpec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698