Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface

third_party/WebKit/Source/core/svg/SVGViewSpec.h

 /*
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef SVGViewSpec_h
 #define SVGViewSpec_h
 
-#include "bindings/core/v8/TraceWrapperMember.h"
 #include "core/svg/SVGFitToViewBox.h"
 #include "core/svg/SVGSVGElement.h"
 #include "core/svg/SVGZoomAndPan.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
-                          public ScriptWrappable,
                           public SVGZoomAndPan,

[foolip, 2016/11/08 09:42:42]

Have you verified that both of these still need to be inherited?

[fs, 2016/11/08 10:29:40]

With the setZoomAndPan overrides below (which think should be dead) gone I don't
think this is needed. It's possible some form of storage will be needed though
still.

[Shanmuga Pandi, 2016/11/09 06:34:56]

though setZoomAndPan overrides, but parseViewSpecInternal() uses parseZoomAndPan
etc which internally alters zoomAndPan value.

[Shanmuga Pandi, 2016/11/09 06:34:56]

I have checked. It seems both are needed.

[fs, 2016/11/09 11:39:53]

Acknowledged. But just removing the setZoomAndPan overrides ought to work,
right?

[Shanmuga Pandi, 2016/11/09 12:00:06]

Not sure.
Do you want to remove below two ?
void setZoomAndPan(unsigned short value) {} // read only
void setZoomAndPan(unsigned short value, ExceptionState&);

[fs, 2016/11/09 12:13:05]

Yes, at the very least the second one. Removing the first one would probably
even fix a "bug" (since we would then properly inherit the value of the
<view>/<svg> element.)

[Shanmuga Pandi, 2016/11/11 12:35:50]

Done.

                           public SVGFitToViewBox {
-  DEFINE_WRAPPERTYPEINFO();
   USING_GARBAGE_COLLECTED_MIXIN(SVGViewSpec);
 
  public:
   static SVGViewSpec* create(SVGSVGElement* contextElement) {
     return new SVGViewSpec(contextElement);
   }
 
   bool parseViewSpec(const String&);
   void reset();
-  void detachContextElement();
   template <typename T>
   void inheritViewAttributesFromElement(T*);
 
-  // JS API
   SVGTransformList* transform() {
     return m_transform ? m_transform->baseValue() : 0;
   }
-  SVGTransformListTearOff* transformFromJavascript() {
-    return m_transform ? m_transform->baseVal() : 0;
-  }
-  SVGElement* viewTarget() const;
-  String viewBoxString() const;
-  String preserveAspectRatioString() const;
-  String transformString() const;
-  String viewTargetString() const { return m_viewTargetString; }
   // override SVGZoomAndPan.setZoomAndPan so can throw exception on write
   void setZoomAndPan(unsigned short value) {}  // read only
   void setZoomAndPan(unsigned short value, ExceptionState&);
 
   DECLARE_VIRTUAL_TRACE();
   DECLARE_VIRTUAL_TRACE_WRAPPERS();

[fs, 2016/11/08 12:42:41]

I believe this is now useless (no longer any wrapper on this object), as well as
the TraceWrapperMember below (which could be turned into a regular Member now.)

[Shanmuga Pandi, 2016/11/09 06:34:56]

Done.

 
   SVGSVGElement* contextElement() { return m_contextElement.get(); }
 
  private:
   explicit SVGViewSpec(SVGSVGElement*);
 
   template <typename CharType>
   bool parseViewSpecInternal(const CharType* ptr, const CharType* end);
 

[fs, 2016/11/08 10:29:40]

(...i.e these...)

   TraceWrapperMember<SVGSVGElement> m_contextElement;
   Member<SVGAnimatedTransformList> m_transform;
   String m_viewTargetString;
 };
 
 template <typename T>
 void SVGViewSpec::inheritViewAttributesFromElement(T* inheritFromElement) {
   if (!inheritFromElement->hasEmptyViewBox())
     viewBox()->baseValue()->setValue(
         inheritFromElement->viewBox()->currentValue()->value());
 
   if (inheritFromElement->preserveAspectRatio()->isSpecified()) {
     preserveAspectRatio()->baseValue()->setAlign(
         inheritFromElement->preserveAspectRatio()->currentValue()->align());
     preserveAspectRatio()->baseValue()->setMeetOrSlice(
         inheritFromElement->preserveAspectRatio()
             ->currentValue()
             ->meetOrSlice());
   }
 
   if (inheritFromElement->hasAttribute(SVGNames::zoomAndPanAttr))
     setZoomAndPan(inheritFromElement->zoomAndPan());
 }
 
 }  // namespace blink
 
 #endif  // SVGViewSpec_h