Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface

third_party/WebKit/Source/core/svg/SVGViewSpec.h

Index: third_party/WebKit/Source/core/svg/SVGViewSpec.h
diff --git a/third_party/WebKit/Source/core/svg/SVGViewSpec.h b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
index 24efc8e47601737562a4afc5b360ca8898372001..47af75f7d5bf2fe71038d467350a63b61727be0f 100644
--- a/third_party/WebKit/Source/core/svg/SVGViewSpec.h
+++ b/third_party/WebKit/Source/core/svg/SVGViewSpec.h
@@ -20,7 +20,6 @@
 #ifndef SVGViewSpec_h
 #define SVGViewSpec_h
 
-#include "bindings/core/v8/TraceWrapperMember.h"
 #include "core/svg/SVGFitToViewBox.h"
 #include "core/svg/SVGSVGElement.h"
 #include "core/svg/SVGZoomAndPan.h"
@@ -29,10 +28,8 @@
 namespace blink {
 
 class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
-                          public ScriptWrappable,
                           public SVGZoomAndPan,

[foolip, 2016/11/08 09:42:42]

Have you verified that both of these still need to be inherited?

[fs, 2016/11/08 10:29:40]

With the setZoomAndPan overrides below (which think should be dead) gone I don't
think this is needed. It's possible some form of storage will be needed though
still.

[Shanmuga Pandi, 2016/11/09 06:34:56]

though setZoomAndPan overrides, but parseViewSpecInternal() uses parseZoomAndPan
etc which internally alters zoomAndPan value.

[Shanmuga Pandi, 2016/11/09 06:34:56]

I have checked. It seems both are needed.

[fs, 2016/11/09 11:39:53]

Acknowledged. But just removing the setZoomAndPan overrides ought to work,
right?

[Shanmuga Pandi, 2016/11/09 12:00:06]

Not sure.
Do you want to remove below two ?
void setZoomAndPan(unsigned short value) {} // read only
void setZoomAndPan(unsigned short value, ExceptionState&);

[fs, 2016/11/09 12:13:05]

Yes, at the very least the second one. Removing the first one would probably
even fix a "bug" (since we would then properly inherit the value of the
<view>/<svg> element.)

[Shanmuga Pandi, 2016/11/11 12:35:50]

Done.

                           public SVGFitToViewBox {
-  DEFINE_WRAPPERTYPEINFO();
   USING_GARBAGE_COLLECTED_MIXIN(SVGViewSpec);
 
  public:
@@ -42,22 +39,12 @@ class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,
 
   bool parseViewSpec(const String&);
   void reset();
-  void detachContextElement();
   template <typename T>
   void inheritViewAttributesFromElement(T*);
 
-  // JS API
   SVGTransformList* transform() {
     return m_transform ? m_transform->baseValue() : 0;
   }
-  SVGTransformListTearOff* transformFromJavascript() {
-    return m_transform ? m_transform->baseVal() : 0;
-  }
-  SVGElement* viewTarget() const;
-  String viewBoxString() const;
-  String preserveAspectRatioString() const;
-  String transformString() const;
-  String viewTargetString() const { return m_viewTargetString; }
   // override SVGZoomAndPan.setZoomAndPan so can throw exception on write
   void setZoomAndPan(unsigned short value) {}  // read only
   void setZoomAndPan(unsigned short value, ExceptionState&);