Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface

Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
Committed: https://crrev.com/b5891de613454cbb79dbcce852396649bf8c5342
Cr-Commit-Position: refs/heads/master@{#431868}

[Shanmuga Pandi, 2016-11-08 09:01:55]

Description was changed from

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
==========

to

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
==========

[Shanmuga Pandi, 2016-11-08 09:07:01]

shanmuga.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Shanmuga Pandi, 2016-11-08 09:07:02]

PTAL!!!

[foolip, 2016-11-08 09:42:42]

LGTM % possible simplification. You'll also need to update
LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
and
LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt.

Please wait for fs to review also.

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
Have you verified that both of these still need to be inherited?

[fs, 2016-11-08 10:29:40]

lgtm

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/08 at 09:42:42, foolip wrote:
> Have you verified that both of these still need to be inherited?

With the setZoomAndPan overrides below (which think should be dead) gone I don't
think this is needed. It's possible some form of storage will be needed though
still.

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:62: 
(...i.e these...)

[fs, 2016-11-08 12:42:42]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:53:
DECLARE_VIRTUAL_TRACE_WRAPPERS();
I believe this is now useless (no longer any wrapper on this object), as well as
the TraceWrapperMember below (which could be turned into a regular Member now.)

[Shanmuga Pandi, 2016-11-09 06:34:30]

On 2016/11/08 09:42:42, foolip wrote:
> LGTM % possible simplification. You'll also need to update
>
LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
> and
>
LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt.
> 

Done!

[Shanmuga Pandi, 2016-11-09 06:34:56]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/08 09:42:42, foolip wrote:
> Have you verified that both of these still need to be inherited?

I have checked. It seems both are needed.

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/08 10:29:40, fs wrote:
> On 2016/11/08 at 09:42:42, foolip wrote:
> > Have you verified that both of these still need to be inherited?
> 
> With the setZoomAndPan overrides below (which think should be dead) gone I
don't
> think this is needed. It's possible some form of storage will be needed though
> still.

though setZoomAndPan overrides, but parseViewSpecInternal() uses parseZoomAndPan
etc which internally alters zoomAndPan value.

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:53:
DECLARE_VIRTUAL_TRACE_WRAPPERS();
On 2016/11/08 12:42:41, fs wrote:
> I believe this is now useless (no longer any wrapper on this object), as well
as
> the TraceWrapperMember below (which could be turned into a regular Member
now.)

Done.

[Shanmuga Pandi, 2016-11-09 06:35:28]

The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 06:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shanmuga Pandi, 2016-11-09 07:01:29]

shanmuga.m@samsung.com changed reviewers:
+ timvolodine@chromium.org

[Shanmuga Pandi, 2016-11-09 07:01:29]

timvolodine@chromium.org: Please review changes in android_webview

[commit-bot: I haz the power, 2016-11-09 08:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 08:38:11]

Dry run: This issue passed the CQ dry run.

[fs, 2016-11-09 11:39:54]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/09 at 06:34:56, Shanmuga Pandi wrote:
> On 2016/11/08 10:29:40, fs wrote:
> > On 2016/11/08 at 09:42:42, foolip wrote:
> > > Have you verified that both of these still need to be inherited?
> > 
> > With the setZoomAndPan overrides below (which think should be dead) gone I
don't
> > think this is needed. It's possible some form of storage will be needed
though
> > still.
> 
> though setZoomAndPan overrides, but parseViewSpecInternal() uses
parseZoomAndPan etc which internally alters zoomAndPan value.

Acknowledged. But just removing the setZoomAndPan overrides ought to work,
right?

[Shanmuga Pandi, 2016-11-09 12:00:07]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/09 11:39:53, fs wrote:
> On 2016/11/09 at 06:34:56, Shanmuga Pandi wrote:
> > On 2016/11/08 10:29:40, fs wrote:
> > > On 2016/11/08 at 09:42:42, foolip wrote:
> > > > Have you verified that both of these still need to be inherited?
> > > 
> > > With the setZoomAndPan overrides below (which think should be dead) gone I
> don't
> > > think this is needed. It's possible some form of storage will be needed
> though
> > > still.
> > 
> > though setZoomAndPan overrides, but parseViewSpecInternal() uses
> parseZoomAndPan etc which internally alters zoomAndPan value.
> 
> Acknowledged. But just removing the setZoomAndPan overrides ought to work,
> right?

Not sure.
Do you want to remove below two ?
void setZoomAndPan(unsigned short value) {} // read only
void setZoomAndPan(unsigned short value, ExceptionState&);

[fs, 2016-11-09 12:13:05]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/09 at 12:00:06, Shanmuga Pandi wrote:
> On 2016/11/09 11:39:53, fs wrote:
> > On 2016/11/09 at 06:34:56, Shanmuga Pandi wrote:
> > > On 2016/11/08 10:29:40, fs wrote:
> > > > On 2016/11/08 at 09:42:42, foolip wrote:
> > > > > Have you verified that both of these still need to be inherited?
> > > > 
> > > > With the setZoomAndPan overrides below (which think should be dead) gone
I
> > don't
> > > > think this is needed. It's possible some form of storage will be needed
> > though
> > > > still.
> > > 
> > > though setZoomAndPan overrides, but parseViewSpecInternal() uses
> > parseZoomAndPan etc which internally alters zoomAndPan value.
> > 
> > Acknowledged. But just removing the setZoomAndPan overrides ought to work,
> > right?
> 
> Not sure.
> Do you want to remove below two ?
> void setZoomAndPan(unsigned short value) {} // read only
> void setZoomAndPan(unsigned short value, ExceptionState&);

Yes, at the very least the second one. Removing the first one would probably
even fix a "bug" (since we would then properly inherit the value of the
<view>/<svg> element.)

[timvolodine, 2016-11-09 20:06:50]

On 2016/11/09 07:01:29, Shanmuga Pandi wrote:
> mailto:timvolodine@chromium.org: Please review changes in android_webview

android_webview/.. -- lgtm

[Shanmuga Pandi, 2016-11-11 12:35:51]

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right):

https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan,
On 2016/11/09 12:13:05, fs wrote:
> On 2016/11/09 at 12:00:06, Shanmuga Pandi wrote:
> > On 2016/11/09 11:39:53, fs wrote:
> > > On 2016/11/09 at 06:34:56, Shanmuga Pandi wrote:
> > > > On 2016/11/08 10:29:40, fs wrote:
> > > > > On 2016/11/08 at 09:42:42, foolip wrote:
> > > > > > Have you verified that both of these still need to be inherited?
> > > > > 
> > > > > With the setZoomAndPan overrides below (which think should be dead)
gone
> I
> > > don't
> > > > > think this is needed. It's possible some form of storage will be
needed
> > > though
> > > > > still.
> > > > 
> > > > though setZoomAndPan overrides, but parseViewSpecInternal() uses
> > > parseZoomAndPan etc which internally alters zoomAndPan value.
> > > 
> > > Acknowledged. But just removing the setZoomAndPan overrides ought to work,
> > > right?
> > 
> > Not sure.
> > Do you want to remove below two ?
> > void setZoomAndPan(unsigned short value) {} // read only
> > void setZoomAndPan(unsigned short value, ExceptionState&);
> 
> Yes, at the very least the second one. Removing the first one would probably
> even fix a "bug" (since we would then properly inherit the value of the
> <view>/<svg> element.)

Done.

[Shanmuga Pandi, 2016-11-11 12:36:36]

The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 12:36:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 14:23:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 14:23:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shanmuga Pandi, 2016-11-14 08:38:21]

The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 08:38:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 10:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 10:35:49]

Dry run: This issue passed the CQ dry run.

[Shanmuga Pandi, 2016-11-14 10:43:24]

The CQ bit was unchecked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-11-14 10:43:44]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-11-14 10:43:44]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com,
foolip@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2485113002/#ps60001
(title: "Fix layouttest failure")

[commit-bot: I haz the power, 2016-11-14 10:44:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 10:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 10:51:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shanmuga Pandi, 2016-11-14 11:30:05]

The CQ bit was unchecked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-11-14 11:30:15]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-11-14 11:30:15]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com,
timvolodine@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2485113002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-14 11:30:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 12:57:43]

Description was changed from

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
==========

to

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
==========

[commit-bot: I haz the power, 2016-11-14 12:57:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-14 12:59:53]

Description was changed from

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445
==========

to

==========
Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec
interface

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM

BUG=629445

Committed: https://crrev.com/b5891de613454cbb79dbcce852396649bf8c5342
Cr-Commit-Position: refs/heads/master@{#431868}
==========

[commit-bot: I haz the power, 2016-11-14 12:59:54]

Patchset 5 (id:??) landed as
https://crrev.com/b5891de613454cbb79dbcce852396649bf8c5342
Cr-Commit-Position: refs/heads/master@{#431868}