Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2485113002: Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface (Closed)

Created:
4 years, 1 month ago by Shanmuga Pandi
Modified:
4 years, 1 month ago
Reviewers:
fs, timvolodine, foolip
CC:
fs, android-webview-reviews_chromium.org, blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM BUG=629445 Committed: https://crrev.com/b5891de613454cbb79dbcce852396649bf8c5342 Cr-Commit-Position: refs/heads/master@{#431868}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Align with review comments #

Patch Set 3 : Removed setZoomAndPan() #

Patch Set 4 : Fix layouttest failure #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -425 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/detached-outermost-svg-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/script-tests/global-constructors.js View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGViewSpec-defaults.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGViewSpec-defaults-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGViewSpec-invalid-ref-crash.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGViewSpec-defaults.js View 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.h View 1 2 4 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.cpp View 1 2 3 chunks +1 line, -50 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGViewSpec.idl View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 41 (24 generated)
Shanmuga Pandi
PTAL!!!
4 years, 1 month ago (2016-11-08 09:07:02 UTC) #3
foolip
LGTM % possible simplification. You'll also need to update LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt and LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt. Please wait for ...
4 years, 1 month ago (2016-11-08 09:42:42 UTC) #4
fs
lgtm https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/08 at 09:42:42, foolip wrote: ...
4 years, 1 month ago (2016-11-08 10:29:40 UTC) #5
fs
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode53 third_party/WebKit/Source/core/svg/SVGViewSpec.h:53: DECLARE_VIRTUAL_TRACE_WRAPPERS(); I believe this is now useless (no longer ...
4 years, 1 month ago (2016-11-08 12:42:42 UTC) #6
Shanmuga Pandi
On 2016/11/08 09:42:42, foolip wrote: > LGTM % possible simplification. You'll also need to update ...
4 years, 1 month ago (2016-11-09 06:34:30 UTC) #7
Shanmuga Pandi
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/08 09:42:42, foolip wrote: > Have ...
4 years, 1 month ago (2016-11-09 06:34:56 UTC) #8
Shanmuga Pandi
timvolodine@chromium.org: Please review changes in android_webview
4 years, 1 month ago (2016-11-09 07:01:29 UTC) #12
fs
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/09 at 06:34:56, Shanmuga Pandi wrote: ...
4 years, 1 month ago (2016-11-09 11:39:54 UTC) #15
Shanmuga Pandi
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/09 11:39:53, fs wrote: > On ...
4 years, 1 month ago (2016-11-09 12:00:07 UTC) #16
fs
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/09 at 12:00:06, Shanmuga Pandi wrote: ...
4 years, 1 month ago (2016-11-09 12:13:05 UTC) #17
timvolodine
On 2016/11/09 07:01:29, Shanmuga Pandi wrote: > mailto:timvolodine@chromium.org: Please review changes in android_webview android_webview/.. -- ...
4 years, 1 month ago (2016-11-09 20:06:50 UTC) #18
Shanmuga Pandi
https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h File third_party/WebKit/Source/core/svg/SVGViewSpec.h (right): https://codereview.chromium.org/2485113002/diff/1/third_party/WebKit/Source/core/svg/SVGViewSpec.h#newcode31 third_party/WebKit/Source/core/svg/SVGViewSpec.h:31: public SVGZoomAndPan, On 2016/11/09 12:13:05, fs wrote: > On ...
4 years, 1 month ago (2016-11-11 12:35:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485113002/60001
4 years, 1 month ago (2016-11-14 10:44:06 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/303274)
4 years, 1 month ago (2016-11-14 10:51:05 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485113002/80001
4 years, 1 month ago (2016-11-14 11:30:25 UTC) #37
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-14 12:57:44 UTC) #39
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 12:59:54 UTC) #41
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b5891de613454cbb79dbcce852396649bf8c5342
Cr-Commit-Position: refs/heads/master@{#431868}

Powered by Google App Engine
This is Rietveld 408576698