Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2485043003: arc: Make IntentHelper::OpenFileToRead's return value nullable (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Make IntentHelper::OpenFileToRead's return value nullable Version number is not changed as this method has not been implemented by Android side yet. BUG=654684 Committed: https://crrev.com/2eb325852a4e5e6509de26200b35be3ff85f8c27 Cr-Commit-Position: refs/heads/master@{#430726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/arc/common/intent_helper.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
hashimoto
4 years, 1 month ago (2016-11-08 19:31:52 UTC) #2
rickyz (no longer on Chrome)
lgtm
4 years, 1 month ago (2016-11-08 21:26:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485043003/1
4 years, 1 month ago (2016-11-08 21:46:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:52:33 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:57:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2eb325852a4e5e6509de26200b35be3ff85f8c27
Cr-Commit-Position: refs/heads/master@{#430726}

Powered by Google App Engine
This is Rietveld 408576698