components/arc/common/intent_helper.mojom - Issue 2485043003: arc: Make IntentHelper::OpenFileToRead's return value nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/common/intent_helper.mojom

Issue 2485043003: arc: Make IntentHelper::OpenFileToRead's return value nullable (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/common/intent_helper.mojom

diff --git a/components/arc/common/intent_helper.mojom b/components/arc/common/intent_helper.mojom

index ed4f217bb620e459b4651800a4eabf80e401bf9d..1bc7c4558f9da9d7210c9826d79f714c69c34880 100644

--- a/components/arc/common/intent_helper.mojom

+++ b/components/arc/common/intent_helper.mojom

@@ -136,7 +136,7 @@ interface IntentHelperInstance {

// Asks the ContentResolver to get an FD to read the file specified by the

// URL.

- [MinVersion=15] OpenFileToRead@12(string url) => (handle fd);

+ [MinVersion=15] OpenFileToRead@12(string url) => (handle? fd);

// Requests 48dp * 48dp icons of the |activities| suitable for the

// |scale_factor|. An array of icon data will be returned.

« no previous file with comments | « no previous file | no next file » | no next file with comments »