Issue 2485004: Attempt to fix flaky OmniboxApiTest.Basic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2485004: Attempt to fix flaky OmniboxApiTest.Basic. (Closed)

Created:
10 years, 6 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Visibility:
Public.

Description

Attempt to fix flaky OmniboxApiTest.Basic. I'm making an educated guess that the TemplateURLModel wasn't loaded by the time we needed a keyword, so let's just wait for it to load. BUG=45588 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48729

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	chrome/browser/extensions/extension_omnibox_apitest.cc	View		3 chunks	+11 lines, -8 lines	1 comment	Download
	M	chrome/test/data/extensions/api_test/omnibox/test.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

10 years, 6 months ago (2010-06-02 02:57:19 UTC) #2

LGTM

http://codereview.chromium.org/2485004/diff/1/2
File chrome/browser/extensions/extension_omnibox_apitest.cc (right):

http://codereview.chromium.org/2485004/diff/1/2#newcode1
chrome/browser/extensions/extension_omnibox_apitest.cc:1: // Copyright (c) 2009
The Chromium Authors. All rights reserved.
Nit: 2010

Expand Messages | Collapse Messages