chrome/test/data/extensions/api_test/omnibox/test.html - Issue 2485004: Attempt to fix flaky OmniboxApiTest.Basic.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/omnibox/test.html

Issue 2485004: Attempt to fix flaky OmniboxApiTest.Basic. (Closed)

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <script>	1 <script>

2 if (!chrome.omnibox) {	2 if (!chrome.omnibox) {

3 chrome.omnibox = chrome.experimental.omnibox;	3 chrome.omnibox = chrome.experimental.omnibox;

4 }	4 }

5	5

6 chrome.experimental.omnibox.onInputChanged.addListener(	6 chrome.omnibox.onInputChanged.addListener(

7 function(text, suggest) {	7 function(text, suggest) {

8 suggest([	8 suggest([

9 {content: text + "n1", description: "description1"},	9 {content: text + "n1", description: "description1"},

10 {content: text + "n2", description: "description2"},	10 {content: text + "n2", description: "description2"},

11 {content: text + "n3", description: "description3"}	11 {content: text + "n3", description: "description3"}

12 ]);	12 ]);

13 });	13 });

14	14

15 chrome.experimental.omnibox.onInputEntered.addListener(	15 chrome.omnibox.onInputEntered.addListener(

16 function(text) {	16 function(text) {

17 chrome.test.assertEq("command", text);	17 chrome.test.assertEq("command", text);

18 chrome.test.notifyPass();	18 chrome.test.notifyPass();

19 });	19 });

20	20

21 // Now we wait for the input events to fire.	21 // Now we wait for the input events to fire.

22 chrome.test.notifyPass();	22 chrome.test.notifyPass();

23 </script>	23 </script>

OLD	NEW