Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2484813005: Remove DCHECK when handle stuffing fails. (Closed)

Created:
4 years, 1 month ago by jbauman
Modified:
4 years, 1 month ago
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org, rickyz+watch_chromium.org, ynovikov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK when handle stuffing fails. This seems to be causing a lot of flakes on the Win7 Intel GPU FYI bot. BUG=649904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/da7006ebeb66503c5988482e3631d43d44f5c74c Cr-Commit-Position: refs/heads/master@{#431049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M sandbox/win/src/handle_closer_agent.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jbauman
4 years, 1 month ago (2016-11-09 01:20:30 UTC) #4
Will Harris
lgtm
4 years, 1 month ago (2016-11-09 01:28:37 UTC) #6
Ken Russell (switch to Gerrit)
I'm not sure why https://codereview.chromium.org/2451963002/ wasn't approved but I'm CQ'ing this now as it's severely ...
4 years, 1 month ago (2016-11-09 22:05:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484813005/1
4 years, 1 month ago (2016-11-09 22:06:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 22:12:51 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 22:24:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da7006ebeb66503c5988482e3631d43d44f5c74c
Cr-Commit-Position: refs/heads/master@{#431049}

Powered by Google App Engine
This is Rietveld 408576698