Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: sandbox/win/src/handle_closer_agent.cc

Issue 2484813005: Remove DCHECK when handle stuffing fails. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/handle_closer_agent.cc
diff --git a/sandbox/win/src/handle_closer_agent.cc b/sandbox/win/src/handle_closer_agent.cc
index c18fef4e3707a8616fc2d642eafc6410b672a88b..69a33ecfadcab04974cbda56b963cbe93b2c5062 100644
--- a/sandbox/win/src/handle_closer_agent.cc
+++ b/sandbox/win/src/handle_closer_agent.cc
@@ -85,9 +85,8 @@ bool HandleCloserAgent::AttemptToStuffHandleSlot(HANDLE closed_handle,
for (HANDLE h : to_close)
::CloseHandle(h);
- // Useful to know when we're not able to stuff handles.
- DCHECK(dup_dummy == closed_handle);
-
+ // TODO(wfh): Investigate why stuffing handles sometimes fails.
+ // http://crbug.com/649904
return dup_dummy == closed_handle;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698