Fix screen flicker when resizing CRD window in split-screen mode

Fix screen flicker when resizing CRD window in split-screen mode

This problem had two sources:
1.) The default background color for Android apps is white, but we use
black to clear our canvas.  When dragging, this white background is
shown when the window is resized past the boundaries of the image we
render.  When the user stops dragging and the window is resized, white
is briefly shown followed by black.

The fix here is to use black for our default background color.  DEBUG
builds will show a flash since the debug color is green, but Release
builds will look clean.

2.) When resizing, we received events in a different order than when we
first start the Desktop activity.  These events could cause a premature
reposition of the canvas (due to either screen or image dimensions not
being set).  If we didn't have both, our calculations would be off and
we would render the image incorrectly for one frame before receiving the
rest of the info and correctly drawing the image.  The differences in
these two frames would cause a flash.

The fix here is to ensure we have both screen and image dimensions
before repositioning the image and requesting the frame to be rendered.

BUG=662456
Committed: https://crrev.com/41c6db6d1a394e6e3a12c60ad7a4696045c527bf
Cr-Commit-Position: refs/heads/master@{#430378}

[joedow, 2016-11-07 18:27:22]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-11-07 18:36:58]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-11-07 18:36:59]

PTAL!

[commit-bot: I haz the power, 2016-11-07 18:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 18:38:35]

Dry run: This issue passed the CQ dry run.

[Lambros, 2016-11-07 20:36:25]

lgtm

https://codereview.chromium.org/2484743003/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2484743003/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:137:
getWindow().setBackgroundDrawable(new ColorDrawable(Color.BLACK));
Would Color.TRANSPARENT be better?

[joedow, 2016-11-07 21:12:44]

Thanks!

https://codereview.chromium.org/2484743003/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2484743003/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:137:
getWindow().setBackgroundDrawable(new ColorDrawable(Color.BLACK));
On 2016/11/07 20:36:25, Lambros wrote:
> Would Color.TRANSPARENT be better?

BLACK and TRANSPARENT have a similar effect on my test device (i.e. they both 
end up displayed as black).  I prefer the opaque color just to be explicit about
what we want.

[joedow, 2016-11-07 21:12:49]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:18:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-07 21:32:55]

Description was changed from

==========
Fix screen flicker when resizing CRD window in split-screen mode

This problem had two sources:
1.) The default background color for Android apps is white, but we use
black to clear our canvas.  When dragging, this white background is
shown when the window is resized past the boundaries of the image we
render.  When the user stops dragging and the window is resized, white
is briefly shown followed by black.

The fix here is to use black for our default background color.  DEBUG
builds will show a flash since the debug color is green, but Release
builds will look clean.

2.) When resizing, we received events in a different order than when we
first start the Desktop activity.  These events could cause a premature
reposition of the canvas (due to either screen or image dimensions not
being set).  If we didn't have both, our calculations would be off and
we would render the image incorrectly for one frame before receiving the
rest of the info and correctly drawing the image.  The differences in
these two frames would cause a flash.

The fix here is to ensure we have both screen and image dimensions
before repositioning the image and requesting the frame to be rendered.

BUG=662456
==========

to

==========
Fix screen flicker when resizing CRD window in split-screen mode

This problem had two sources:
1.) The default background color for Android apps is white, but we use
black to clear our canvas.  When dragging, this white background is
shown when the window is resized past the boundaries of the image we
render.  When the user stops dragging and the window is resized, white
is briefly shown followed by black.

The fix here is to use black for our default background color.  DEBUG
builds will show a flash since the debug color is green, but Release
builds will look clean.

2.) When resizing, we received events in a different order than when we
first start the Desktop activity.  These events could cause a premature
reposition of the canvas (due to either screen or image dimensions not
being set).  If we didn't have both, our calculations would be off and
we would render the image incorrectly for one frame before receiving the
rest of the info and correctly drawing the image.  The differences in
these two frames would cause a flash.

The fix here is to ensure we have both screen and image dimensions
before repositioning the image and requesting the frame to be rendered.

BUG=662456

Committed: https://crrev.com/41c6db6d1a394e6e3a12c60ad7a4696045c527bf
Cr-Commit-Position: refs/heads/master@{#430378}
==========

[commit-bot: I haz the power, 2016-11-07 21:32:56]

Patchset 2 (id:??) landed as
https://crrev.com/41c6db6d1a394e6e3a12c60ad7a4696045c527bf
Cr-Commit-Position: refs/heads/master@{#430378}

[Yuwei, 2016-11-07 21:36:15]

yuweih@chromium.org changed reviewers:
+ yuweih@chromium.org

[Yuwei, 2016-11-07 21:36:15]

BTW have you tried changing the glClearColor in GlRenderer to transparent and
directly set the black/green background in Java? If that works then I think it
may get rid of the flickering in debug build.