Updating Toolbar Autohide behavior to account for multi-window mode.

Updating Toolbar Autohide behavior to account for multi-window mode.

This change updates the Desktop activity to be Multi-Window aware and to
disable the Autohide Toolbar behavior when in that mode.

When an activity is in Multi-window mode, the System UI is always
present (and cannot be dismissed).  If an activity tries to dismiss the
System UI, no effect will take place.  Thus we should not even set up
the autohide timer in this scenario.

With respect to multi-window mode, there is a method that can be called
to ascertain which mode the activity is in, however one catch is that
you cannot call it from OnCreate due to a race condition (OnResume is
ok).  Thus I have set up a helper function with a precondition (called
after OnResume()) which will return whether it is in Multi-window mode.

One last change is to leave the video stream running if the activity is
paused in Multi-window mode.  When two activities are in split-screen
mode, the currently selected activity is in the running state and the
other is in a paused state.  I think we should continune updating the
video surface if we are in split screen and paused as the user may be
waiting for an action to occur before switching back to our activity.
Thus I have updated the logic to only disable the video stream on pause
if the activity is not in Multi-window mode (it will still be stopped
when the activity is stopped).

BUG=631266
Committed: https://crrev.com/847adc99338f55ab58704c17dbc2c9e2c54b8fcc
Cr-Commit-Position: refs/heads/master@{#429953}

[joedow, 2016-11-04 17:22:35]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:22:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-11-04 17:22:56]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-11-04 17:22:57]

PTAL!

[commit-bot: I haz the power, 2016-11-04 17:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:35:02]

Dry run: This issue passed the CQ dry run.

[Lambros, 2016-11-04 18:03:45]

lgtm

[joedow, 2016-11-04 18:08:15]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:08:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:15:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 18:18:53]

Description was changed from

==========
Updating Toolbar Autohide behavior to account for multi-window mode.

This change updates the Desktop activity to be Multi-Window aware and to
disable the Autohide Toolbar behavior when in that mode.

When an activity is in Multi-window mode, the System UI is always
present (and cannot be dismissed).  If an activity tries to dismiss the
System UI, no effect will take place.  Thus we should not even set up
the autohide timer in this scenario.

With respect to multi-window mode, there is a method that can be called
to ascertain which mode the activity is in, however one catch is that
you cannot call it from OnCreate due to a race condition (OnResume is
ok).  Thus I have set up a helper function with a precondition (called
after OnResume()) which will return whether it is in Multi-window mode.

One last change is to leave the video stream running if the activity is
paused in Multi-window mode.  When two activities are in split-screen
mode, the currently selected activity is in the running state and the
other is in a paused state.  I think we should continune updating the
video surface if we are in split screen and paused as the user may be
waiting for an action to occur before switching back to our activity.
Thus I have updated the logic to only disable the video stream on pause
if the activity is not in Multi-window mode (it will still be stopped
when the activity is stopped).

BUG=631266
==========

to

==========
Updating Toolbar Autohide behavior to account for multi-window mode.

This change updates the Desktop activity to be Multi-Window aware and to
disable the Autohide Toolbar behavior when in that mode.

When an activity is in Multi-window mode, the System UI is always
present (and cannot be dismissed).  If an activity tries to dismiss the
System UI, no effect will take place.  Thus we should not even set up
the autohide timer in this scenario.

With respect to multi-window mode, there is a method that can be called
to ascertain which mode the activity is in, however one catch is that
you cannot call it from OnCreate due to a race condition (OnResume is
ok).  Thus I have set up a helper function with a precondition (called
after OnResume()) which will return whether it is in Multi-window mode.

One last change is to leave the video stream running if the activity is
paused in Multi-window mode.  When two activities are in split-screen
mode, the currently selected activity is in the running state and the
other is in a paused state.  I think we should continune updating the
video surface if we are in split screen and paused as the user may be
waiting for an action to occur before switching back to our activity.
Thus I have updated the logic to only disable the video stream on pause
if the activity is not in Multi-window mode (it will still be stopped
when the activity is stopped).

BUG=631266

Committed: https://crrev.com/847adc99338f55ab58704c17dbc2c9e2c54b8fcc
Cr-Commit-Position: refs/heads/master@{#429953}
==========

[commit-bot: I haz the power, 2016-11-04 18:18:54]

Patchset 1 (id:??) landed as
https://crrev.com/847adc99338f55ab58704c17dbc2c9e2c54b8fcc
Cr-Commit-Position: refs/heads/master@{#429953}