Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
index 952f9cbe6666e9eaa213ec2daff0c9607eeb03b7..79a27c54ea357f8f7706e3fae506ead37c0fe6ff 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
@@ -30,6 +30,7 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/previews_state.h"
#include "content/public/common/resource_type.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/url_request/url_request.h"
@@ -440,17 +441,14 @@ std::unique_ptr<net::URLRequest> OfflinePageRequestJobTest::CreateRequest(
request->set_method(method);
content::ResourceRequestInfo::AllocateForTesting(
- request.get(),
- resource_type,
- nullptr,
- 1, /* render_process_id */
- -1, /* render_view_id */
- 1, /* render_frame_id */
- true, /* is_main_frame */
- false, /* parent_is_main_frame */
- true, /* allow_download */
- true, /* is_async */
- false /* is_using_lofi */);
+ request.get(), resource_type, nullptr, 1, /* render_process_id */
Nico 2017/01/09 22:35:03 nit: if, instead of putting the comment at the end
megjablon 2017/01/10 22:30:01 Done.
+ -1, /* render_view_id */
+ 1, /* render_frame_id */
+ true, /* is_main_frame */
+ false, /* parent_is_main_frame */
+ true, /* allow_download */
+ true, /* is_async */
+ content::PREVIEWS_OFF /* previews_state */);
return request;
}

Powered by Google App Engine
This is Rietveld 408576698