Change Lo-Fi bool to bitmask to support multiple Previews types

chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
 
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
@@ skipping 12 matching lines @@
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/offline_pages/core/client_namespace_constants.h"
 #include "components/offline_pages/core/offline_page_model_impl.h"
 #include "components/previews/core/previews_decider.h"
 #include "components/previews/core/previews_experiments.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/previews_state.h"
 #include "content/public/common/resource_type.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_intercepting_job_factory.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace offline_pages {
@@ skipping 390 matching lines @@
   url_request_delegate_ = base::MakeUnique<TestURLRequestDelegate>(
       base::Bind(&OfflinePageRequestJobTest::ReadCompletedOnIO,
                  base::Unretained(this)));
 
   std::unique_ptr<net::URLRequest> request =
       url_request_context()->CreateRequest(
           url, net::DEFAULT_PRIORITY, url_request_delegate_.get());
   request->set_method(method);
 
   content::ResourceRequestInfo::AllocateForTesting(
-      request.get(),
-      resource_type,
-      nullptr,
-      1,     /* render_process_id */
-      -1,    /* render_view_id */
-      1,     /* render_frame_id */
-      true,  /* is_main_frame */
-      false, /* parent_is_main_frame */
-      true,  /* allow_download */
-      true,  /* is_async */
-      false  /* is_using_lofi */);
+      request.get(), resource_type, nullptr, 1, /* render_process_id */

[Nico, 2017/01/09 22:35:03]

nit: if, instead of putting the comment at the end, you say `...,
/*render_process_id=*/1, /*render_view_id=*/-1, ...` then clang-format will wrap
this a bit nicer

(also, thanks to this nice change, the PREVIEWS_OFF name is now self-explaining
and doesn't need a comment anymore)

[megjablon, 2017/01/10 22:30:01]

Done.

+      -1,                                       /* render_view_id */
+      1,                                        /* render_frame_id */
+      true,                                     /* is_main_frame */
+      false,                                    /* parent_is_main_frame */
+      true,                                     /* allow_download */
+      true,                                     /* is_async */
+      content::PREVIEWS_OFF                     /* previews_state */);
 
   return request;
 }
 
 void
 OfflinePageRequestJobTest::ExpectOneUniqueSampleForAggregatedRequestResult(
     OfflinePageRequestJob::AggregatedRequestResult result) {
   histogram_tester_.ExpectUniqueSample(
       kAggregatedRequestResultHistogram, static_cast<int>(result), 1);
 }
@@ skipping 395 matching lines @@
             offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectOneNonuniqueSampleForAggregatedRequestResult(
       OfflinePageRequestJob::AggregatedRequestResult::
           REDIRECTED_ON_DISCONNECTED_NETWORK);
   ExpectOneNonuniqueSampleForAggregatedRequestResult(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_DISCONNECTED_NETWORK);
 }
 
 }  // namespace offline_pages