Change Lo-Fi bool to bitmask to support multiple Previews types

third_party/WebKit/public/platform/WebURLRequest.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 118 matching lines @@
 
   // Used to report performance metrics timed from the UI action that
   // triggered them (as opposed to navigation start time used in the
   // Navigation Timing API).
   enum InputToLoadPerfMetricReportPolicy {
     NoReport,      // Don't report metrics for this WebURLRequest.
     ReportLink,    // Report metrics with UI action link clicked.
     ReportIntent,  // Report metrics with UI action displayed intent.
   };
 
-  // The LoFi state which determines whether to request a Lo-Fi version of the
-  // resource.
-  enum LoFiState {
-    LoFiUnspecified,  // Let the browser process decide whether or not to
-                      // request the Lo-Fi version.
-    LoFiOff,          // Request a normal (non-Lo-Fi) version of the resource.
-    LoFiOn,           // Request a Lo-Fi version of the resource.
+  // The Previews state which determines whether to request a Preview version of
+  // the resource.
+  enum PreviewsState {
+    PreviewsUnspecified = 0,  // Let the browser process decide whether or
+                              // not to request Preview types.
+    ServerLoFiOn = 1 << 0,    // Request a Lo-Fi version of the resource
+                              // from the server.
+    ClientLoFiOn = 1 << 1,    // Request a Lo-Fi version of the resource
+                              // from the client.
+    PreviewsOff = 1 << 2      // Request a normal (non-Preview) version of

[nasko, 2016/12/12 23:05:41]

Can we add static checks to ensure the two enums don't get out of sync? An
example you can refer to is
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?r....

[megjablon, 2016/12/13 03:03:14]

Excellent idea. I added this to render_frame_impl.cc. Please let me know if it
should live elsewhere.

+                              // the resource.
   };
 
   // Indicates which types of ServiceWorkers should skip handling this request.
   enum class SkipServiceWorker {
     // Request can be handled both by a controlling same-origin worker and
     // a cross-origin foreign fetch service worker.
     None,
     // Request should not be handled by a same-origin controlling worker,
     // but can be intercepted by a foreign fetch service worker.
     Controlling,
@@ skipping 122 matching lines @@
   BLINK_PLATFORM_EXPORT void setFetchRequestMode(FetchRequestMode);
 
   // The credentials mode which will be passed to the ServiceWorker.
   BLINK_PLATFORM_EXPORT FetchCredentialsMode getFetchCredentialsMode() const;
   BLINK_PLATFORM_EXPORT void setFetchCredentialsMode(FetchCredentialsMode);
 
   // The redirect mode which is used in Fetch API.
   BLINK_PLATFORM_EXPORT FetchRedirectMode getFetchRedirectMode() const;
   BLINK_PLATFORM_EXPORT void setFetchRedirectMode(FetchRedirectMode);
 
-  // The LoFi state which determines whether to request a Lo-Fi version of the
-  // resource.
-  BLINK_PLATFORM_EXPORT LoFiState getLoFiState() const;
-  BLINK_PLATFORM_EXPORT void setLoFiState(LoFiState);
+  // The Previews state which determines whether to request a Preview version of
+  // the resource.
+  BLINK_PLATFORM_EXPORT PreviewsState getPreviewsState() const;
+  BLINK_PLATFORM_EXPORT void setPreviewsState(PreviewsState);
 
   // Extra data associated with the underlying resource request. Resource
   // requests can be copied. If non-null, each copy of a resource requests
   // holds a pointer to the extra data, and the extra data pointer will be
   // deleted when the last resource request is destroyed. Setting the extra
   // data pointer will cause the underlying resource request to be
   // dissociated from any existing non-null extra data pointer.
   BLINK_PLATFORM_EXPORT ExtraData* getExtraData() const;
   BLINK_PLATFORM_EXPORT void setExtraData(ExtraData*);
 
@@ skipping 42 matching lines @@
   // instance it contains.
   std::unique_ptr<ResourceRequestContainer> m_ownedResourceRequest;
 
   // Should never be null.
   ResourceRequest* m_resourceRequest;
 };
 
 }  // namespace blink
 
 #endif