Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/WebKit/Source/platform/network/ResourceRequest.cpp

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: use PreviewsState everywhere Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 setSkipServiceWorker(data->m_skipServiceWorker); 74 setSkipServiceWorker(data->m_skipServiceWorker);
75 setShouldResetAppCache(data->m_shouldResetAppCache); 75 setShouldResetAppCache(data->m_shouldResetAppCache);
76 setRequestorID(data->m_requestorID); 76 setRequestorID(data->m_requestorID);
77 setRequestorProcessID(data->m_requestorProcessID); 77 setRequestorProcessID(data->m_requestorProcessID);
78 setAppCacheHostID(data->m_appCacheHostID); 78 setAppCacheHostID(data->m_appCacheHostID);
79 setRequestContext(data->m_requestContext); 79 setRequestContext(data->m_requestContext);
80 setFrameType(data->m_frameType); 80 setFrameType(data->m_frameType);
81 setFetchRequestMode(data->m_fetchRequestMode); 81 setFetchRequestMode(data->m_fetchRequestMode);
82 setFetchCredentialsMode(data->m_fetchCredentialsMode); 82 setFetchCredentialsMode(data->m_fetchCredentialsMode);
83 setFetchRedirectMode(data->m_fetchRedirectMode); 83 setFetchRedirectMode(data->m_fetchRedirectMode);
84 setLoFiState(data->m_loFiState); 84 setPreviewsState(data->m_previewsState);
85 m_referrerPolicy = data->m_referrerPolicy; 85 m_referrerPolicy = data->m_referrerPolicy;
86 m_didSetHTTPReferrer = data->m_didSetHTTPReferrer; 86 m_didSetHTTPReferrer = data->m_didSetHTTPReferrer;
87 m_checkForBrowserSideNavigation = data->m_checkForBrowserSideNavigation; 87 m_checkForBrowserSideNavigation = data->m_checkForBrowserSideNavigation;
88 m_uiStartTime = data->m_uiStartTime; 88 m_uiStartTime = data->m_uiStartTime;
89 m_isExternalRequest = data->m_isExternalRequest; 89 m_isExternalRequest = data->m_isExternalRequest;
90 m_inputPerfMetricReportPolicy = data->m_inputPerfMetricReportPolicy; 90 m_inputPerfMetricReportPolicy = data->m_inputPerfMetricReportPolicy;
91 m_redirectStatus = data->m_redirectStatus; 91 m_redirectStatus = data->m_redirectStatus;
92 } 92 }
93 93
94 ResourceRequest::ResourceRequest(const ResourceRequest&) = default; 94 ResourceRequest::ResourceRequest(const ResourceRequest&) = default;
(...skipping 27 matching lines...) Expand all
122 data->m_skipServiceWorker = m_skipServiceWorker; 122 data->m_skipServiceWorker = m_skipServiceWorker;
123 data->m_shouldResetAppCache = m_shouldResetAppCache; 123 data->m_shouldResetAppCache = m_shouldResetAppCache;
124 data->m_requestorID = m_requestorID; 124 data->m_requestorID = m_requestorID;
125 data->m_requestorProcessID = m_requestorProcessID; 125 data->m_requestorProcessID = m_requestorProcessID;
126 data->m_appCacheHostID = m_appCacheHostID; 126 data->m_appCacheHostID = m_appCacheHostID;
127 data->m_requestContext = m_requestContext; 127 data->m_requestContext = m_requestContext;
128 data->m_frameType = m_frameType; 128 data->m_frameType = m_frameType;
129 data->m_fetchRequestMode = m_fetchRequestMode; 129 data->m_fetchRequestMode = m_fetchRequestMode;
130 data->m_fetchCredentialsMode = m_fetchCredentialsMode; 130 data->m_fetchCredentialsMode = m_fetchCredentialsMode;
131 data->m_fetchRedirectMode = m_fetchRedirectMode; 131 data->m_fetchRedirectMode = m_fetchRedirectMode;
132 data->m_loFiState = m_loFiState; 132 data->m_previewsState = m_previewsState;
133 data->m_referrerPolicy = m_referrerPolicy; 133 data->m_referrerPolicy = m_referrerPolicy;
134 data->m_didSetHTTPReferrer = m_didSetHTTPReferrer; 134 data->m_didSetHTTPReferrer = m_didSetHTTPReferrer;
135 data->m_checkForBrowserSideNavigation = m_checkForBrowserSideNavigation; 135 data->m_checkForBrowserSideNavigation = m_checkForBrowserSideNavigation;
136 data->m_uiStartTime = m_uiStartTime; 136 data->m_uiStartTime = m_uiStartTime;
137 data->m_isExternalRequest = m_isExternalRequest; 137 data->m_isExternalRequest = m_isExternalRequest;
138 data->m_inputPerfMetricReportPolicy = m_inputPerfMetricReportPolicy; 138 data->m_inputPerfMetricReportPolicy = m_inputPerfMetricReportPolicy;
139 data->m_redirectStatus = m_redirectStatus; 139 data->m_redirectStatus = m_redirectStatus;
140 return data; 140 return data;
141 } 141 }
142 142
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 m_intraPriorityValue = 0; 394 m_intraPriorityValue = 0;
395 m_requestorID = 0; 395 m_requestorID = 0;
396 m_requestorProcessID = 0; 396 m_requestorProcessID = 0;
397 m_appCacheHostID = 0; 397 m_appCacheHostID = 0;
398 m_requestContext = WebURLRequest::RequestContextUnspecified; 398 m_requestContext = WebURLRequest::RequestContextUnspecified;
399 m_frameType = WebURLRequest::FrameTypeNone; 399 m_frameType = WebURLRequest::FrameTypeNone;
400 m_fetchRequestMode = WebURLRequest::FetchRequestModeNoCORS; 400 m_fetchRequestMode = WebURLRequest::FetchRequestModeNoCORS;
401 m_fetchCredentialsMode = WebURLRequest::FetchCredentialsModeInclude; 401 m_fetchCredentialsMode = WebURLRequest::FetchCredentialsModeInclude;
402 m_fetchRedirectMode = WebURLRequest::FetchRedirectModeFollow; 402 m_fetchRedirectMode = WebURLRequest::FetchRedirectModeFollow;
403 m_referrerPolicy = ReferrerPolicyDefault; 403 m_referrerPolicy = ReferrerPolicyDefault;
404 m_loFiState = WebURLRequest::LoFiUnspecified; 404 m_previewsState = WebURLRequest::PreviewsState::PreviewsUnspecified;
405 m_didSetHTTPReferrer = false; 405 m_didSetHTTPReferrer = false;
406 m_checkForBrowserSideNavigation = true; 406 m_checkForBrowserSideNavigation = true;
407 m_uiStartTime = 0; 407 m_uiStartTime = 0;
408 m_isExternalRequest = false; 408 m_isExternalRequest = false;
409 m_inputPerfMetricReportPolicy = InputToLoadPerfMetricReportPolicy::NoReport; 409 m_inputPerfMetricReportPolicy = InputToLoadPerfMetricReportPolicy::NoReport;
410 m_redirectStatus = RedirectStatus::NoRedirect; 410 m_redirectStatus = RedirectStatus::NoRedirect;
411 m_requestorOrigin = SecurityOrigin::createUnique(); 411 m_requestorOrigin = SecurityOrigin::createUnique();
412 } 412 }
413 413
414 bool ResourceRequest::needsHTTPOrigin() const { 414 bool ResourceRequest::needsHTTPOrigin() const {
415 if (!httpOrigin().isEmpty()) 415 if (!httpOrigin().isEmpty())
416 return false; // Request already has an Origin header. 416 return false; // Request already has an Origin header.
417 417
418 // Don't send an Origin header for GET or HEAD to avoid privacy issues. 418 // Don't send an Origin header for GET or HEAD to avoid privacy issues.
419 // For example, if an intranet page has a hyperlink to an external web 419 // For example, if an intranet page has a hyperlink to an external web
420 // site, we don't want to include the Origin of the request because it 420 // site, we don't want to include the Origin of the request because it
421 // will leak the internal host name. Similar privacy concerns have lead 421 // will leak the internal host name. Similar privacy concerns have lead
422 // to the widespread suppression of the Referer header at the network 422 // to the widespread suppression of the Referer header at the network
423 // layer. 423 // layer.
424 if (httpMethod() == HTTPNames::GET || httpMethod() == HTTPNames::HEAD) 424 if (httpMethod() == HTTPNames::GET || httpMethod() == HTTPNames::HEAD)
425 return false; 425 return false;
426 426
427 // For non-GET and non-HEAD methods, always send an Origin header so the 427 // For non-GET and non-HEAD methods, always send an Origin header so the
428 // server knows we support this feature. 428 // server knows we support this feature.
429 return true; 429 return true;
430 } 430 }
431 431
432 } // namespace blink 432 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698