Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484623002:
[wasm] Indirect calls without function table cause validation errors. (Closed)
Description[wasm] Indirect calls without function table cause validation errors.
The spec defines that indirect calls in WebAssembly code should cause a
validation error if no function table exists.
The CL contains the following changes:
1) Throw a validation error for indirect calls if the function table
not exist.
2) Do not create TF nodes to throw a runtime error for indirect calls
if the function table does not exist.
3) Fix existing unit tests by creating a dummy function table.
4) Add new a new test which tests that indirect calls without function
table cause a validation error.
R=rossberg@chromium.org
CC=titzer@chromium.org
TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash
Committed: https://crrev.com/4db05d405b564a832476ffbe8e157bab7b608ae0
Cr-Commit-Position: refs/heads/master@{#40852}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Put the validation into the Validate function #Patch Set 3 : Fix another test #Patch Set 4 : Add include #Patch Set 5 : try to export symbols #
Messages
Total messages: 35 (21 generated)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
titzer@chromium.org changed reviewers: + titzer@chromium.org
https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc#new... src/wasm/ast-decoder.cc:1141: if (Validate(pc_, operand) && module_->IsValidTable(table_index)) { Why not just move this logic into the Validate method?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc#new... src/wasm/ast-decoder.cc:1141: if (Validate(pc_, operand) && module_->IsValidTable(table_index)) { On 2016/11/07 at 09:24:11, titzer wrote: > Why not just move this logic into the Validate method? Done. I misunderstood the Validate method.
On 2016/11/07 09:35:56, ahaas wrote: > https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc > File src/wasm/ast-decoder.cc (right): > > https://codereview.chromium.org/2484623002/diff/1/src/wasm/ast-decoder.cc#new... > src/wasm/ast-decoder.cc:1141: if (Validate(pc_, operand) && > module_->IsValidTable(table_index)) { > On 2016/11/07 at 09:24:11, titzer wrote: > > Why not just move this logic into the Validate method? > > Done. I misunderstood the Validate method. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15762) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ahaas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2484623002/#ps40001 (title: "Fix another test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2479283002/ by machenbach@chromium.org. The reason for reverting is: Speculative revert for blocking roll: https://codereview.chromium.org/2479233002/.
Message was sent while issue was closed.
Description was changed from ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash ========== to ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash ==========
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Reopened this to test failing trybot for reland.
On 2016/11/07 at 18:03:52, machenbach wrote: > Reopened this to test failing trybot for reland. PTAL, I fixed the build problem.
On 2016/11/09 08:01:30, ahaas wrote: > On 2016/11/07 at 18:03:52, machenbach wrote: > > Reopened this to test failing trybot for reland. > > PTAL, I fixed the build problem. lgtm
The CQ bit was checked by ahaas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash ========== to ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash ========== to ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash Committed: https://crrev.com/3de5204737d95c6d09fd2685b5d4e45641f5aa5e Cr-Commit-Position: refs/heads/master@{#40802} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/3de5204737d95c6d09fd2685b5d4e45641f5aa5e Cr-Commit-Position: refs/heads/master@{#40802}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash Committed: https://crrev.com/3de5204737d95c6d09fd2685b5d4e45641f5aa5e Cr-Commit-Position: refs/heads/master@{#40802} ========== to ========== [wasm] Indirect calls without function table cause validation errors. The spec defines that indirect calls in WebAssembly code should cause a validation error if no function table exists. The CL contains the following changes: 1) Throw a validation error for indirect calls if the function table not exist. 2) Do not create TF nodes to throw a runtime error for indirect calls if the function table does not exist. 3) Fix existing unit tests by creating a dummy function table. 4) Add new a new test which tests that indirect calls without function table cause a validation error. R=rossberg@chromium.org CC=titzer@chromium.org TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash Committed: https://crrev.com/4db05d405b564a832476ffbe8e157bab7b608ae0 Cr-Commit-Position: refs/heads/master@{#40852} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/4db05d405b564a832476ffbe8e157bab7b608ae0 Cr-Commit-Position: refs/heads/master@{#40852} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
