Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2479283002: Revert of [wasm] Indirect calls without function table cause validation errors. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
titzer, rossberg, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Indirect calls without function table cause validation errors. (patchset #3 id:40001 of https://codereview.chromium.org/2484623002/ ) Reason for revert: Speculative revert for blocking roll: https://codereview.chromium.org/2479233002/ Original issue's description: > [wasm] Indirect calls without function table cause validation errors. > > The spec defines that indirect calls in WebAssembly code should cause a > validation error if no function table exists. > > The CL contains the following changes: > 1) Throw a validation error for indirect calls if the function table > not exist. > 2) Do not create TF nodes to throw a runtime error for indirect calls > if the function table does not exist. > 3) Fix existing unit tests by creating a dummy function table. > 4) Add new a new test which tests that indirect calls without function > table cause a validation error. > > R=rossberg@chromium.org > CC=titzer@chromium.org > > TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash TBR=rossberg@chromium.org,titzer@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/32ec567df153b1dd7e85788adf4bcbd1ac8de66c Cr-Commit-Position: refs/heads/master@{#40811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/wasm/ast-decoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/trap-location.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 5 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [wasm] Indirect calls without function table cause validation errors.
4 years, 1 month ago (2016-11-07 17:56:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479283002/1
4 years, 1 month ago (2016-11-07 17:56:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 17:56:59 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32ec567df153b1dd7e85788adf4bcbd1ac8de66c
Cr-Commit-Position: refs/heads/master@{#40811}

Powered by Google App Engine
This is Rietveld 408576698