Enhance chrome.app.window API with title property

chrome/browser/ui/ash/launcher/launcher_item_controller.h

Index: chrome/browser/ui/ash/launcher/launcher_item_controller.h
diff --git a/chrome/browser/ui/ash/launcher/launcher_item_controller.h b/chrome/browser/ui/ash/launcher/launcher_item_controller.h
index 42b55b838b65b9d6d8281e0b196177f49795ab6b..aacfc5a43e02de2d55453c2e9830ee4c29b70a58 100644
--- a/chrome/browser/ui/ash/launcher/launcher_item_controller.h
+++ b/chrome/browser/ui/ash/launcher/launcher_item_controller.h
@@ -43,6 +43,7 @@ class LauncherItemController : public ash::ShelfItemDelegate {
   LauncherItemController(Type type,
                          const std::string& app_id,
                          const std::string& launch_id,
+                         const std::string& title,

[stevenjb, 2016/11/09 18:42:15]

Adding 'launch_id' to the constructor made sense because it is part of the
unique identifier for the item.

Adding 'title' when it is mostly unused just creates a lot of churn. Instead we
should add a set_title() method. (But also see my other comments).

[Andra Paraschiv, 2016/11/10 07:53:43]

Ok, thank you for this. I will try to modify this to be simpler and without many
code changes.

                          ChromeLauncherController* launcher_controller);
   ~LauncherItemController() override;
 
@@ -51,6 +52,7 @@ class LauncherItemController : public ash::ShelfItemDelegate {
   void set_shelf_id(ash::ShelfID id) { shelf_id_ = id; }
   const std::string& app_id() const { return app_id_; }
   const std::string& launch_id() const { return launch_id_; }
+  const std::string& title() const { return title_; }
   ChromeLauncherController* launcher_controller() const {
     return launcher_controller_;
   }
@@ -96,6 +98,8 @@ class LauncherItemController : public ash::ShelfItemDelegate {
   // multiple shelf items per app. This id is used together with the app_id to
   // uniquely identify each shelf item that has the same app_id.
   const std::string launch_id_;
+  // Title of the window that has its own icon in the shelf.
+  const std::string title_;
   // A unique id assigned by the shelf model for the shelf item.
   ash::ShelfID shelf_id_;
   ChromeLauncherController* launcher_controller_;