Drop Precise blink builders on chromium.webkit, add corresponding Trusty builders.

Drop Precise blink builders, add corresponding Trusty builders.

This CL would:

 - Drop "WebKit Linux Precise" from chromium.webkit
 - Replace "WebKit Linux Precise *" with "WebKit Linux Trusty *".
 - Update config in chromium_tests recipe module.

BUG=660580
Committed: https://chromium.googlesource.com/chromium/tools/build/+/994a2c68356fcde952b49925e6fd8890eab39b59

[qyearsley, 2016-11-08 23:50:50]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-11-08 23:52:27]

Description was changed from

==========
Drop Precise blink builders, add corresponding Trusty builders.

BUG=660580
==========

to

==========
Drop Precise blink builders, add corresponding Trusty builders.

This CL would:

 - Drop "WebKit Linux Precise" from chromium.webkit
 - Replace "WebKit Linux Precise *" with "WebKit Linux Trusty *".
 - Update config in chromium_tests recipe module.

BUG=660580
==========

[qyearsley, 2016-11-08 23:56:32]

Note, I'm not sure whether it's correct to keep the same slaves, or whether we
need to wait for new slaves...

Once it's confirmed what slaves should be used and the CL that updates
mb_config.pyl is committed, then I believe this can be committed, then
chromium.webkit could be restarted.

Then, another similar CL could be made to change the builders on
tryserver.blink, and that master could be restarted.

[Dirk Pranke, 2016-11-10 00:30:20]

I've lost track of what's where. Wasn't there a bug/ticket where you were going
over the upgrades w/ vhang@?

If the machines were upgraded in place already, updating the names is fine.
Otherwise, normally we just set up new machines because it's easier to do that
without downtime.

[qyearsley, 2016-11-10 03:32:32]

qyearsley@chromium.org changed reviewers:
+ vhang@chromium.org

[qyearsley, 2016-11-10 03:40:51]

+vhang@chromium.org

On 2016/11/10 at 00:30:20, dpranke wrote:
> I've lost track of what's where. Wasn't there a bug/ticket where you were
going over the upgrades w/ vhang@?

There was a email thread discussing which slaves would be replaced ("Re: Upgrade
Bots to Trusty"), but I'm not sure whether they're upgraded right now -- 

vhang@, have the slaves vm3-m1, vm4-m1, vm959-m1, build73-m1 been upgraded to
Trusty?

The bug to track changes related to dropping Precise is http://crbug.com/660580,
although we didn't discuss what slaves to upgrade there.

[chromium-reviews, 2016-11-10 18:19:41]

On Wed, Nov 9, 2016 at 7:40 PM, <qyearsley@chromium.org> wrote:

> +vhang@chromium.org
>
> On 2016/11/10 at 00:30:20, dpranke wrote:
> > I've lost track of what's where. Wasn't there a bug/ticket where you were
> going over the upgrades w/ vhang@?
>
> There was a email thread discussing which slaves would be replaced ("Re:
> Upgrade
> Bots to Trusty"), but I'm not sure whether they're upgraded right now --
>
> vhang@, have the slaves vm3-m1, vm4-m1, vm959-m1, build73-m1 been
> upgraded to
> Trusty?
>

*** crbug.com/661834 was opened to replace a few webkit bots with Trusty
GCE bots.


>
> The bug to track changes related to dropping Precise is
> http://crbug.com/660580,
> although we didn't discuss what slaves to upgrade there.
>
>
> https://codereview.chromium.org/2484343002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2016-11-10 18:28:04]

Thanks, Vince! I thought there was a bug somewhere but I wasn't finding it
:).

-- Dirk

On Thu, Nov 10, 2016 at 10:18 AM, Vince Hang <vhang@google.com> wrote:

> On Wed, Nov 9, 2016 at 7:40 PM, <qyearsley@chromium.org> wrote:
>
>> +vhang@chromium.org
>>
>> On 2016/11/10 at 00:30:20, dpranke wrote:
>> > I've lost track of what's where. Wasn't there a bug/ticket where you
>> were
>> going over the upgrades w/ vhang@?
>>
>> There was a email thread discussing which slaves would be replaced ("Re:
>> Upgrade
>> Bots to Trusty"), but I'm not sure whether they're upgraded right now --
>>
>> vhang@, have the slaves vm3-m1, vm4-m1, vm959-m1, build73-m1 been
>> upgraded to
>> Trusty?
>>
>
> *** crbug.com/661834 was opened to replace a few webkit bots with Trusty
> GCE bots.
>
>
>>
>> The bug to track changes related to dropping Precise is
>> http://crbug.com/660580,
>> although we didn't discuss what slaves to upgrade there.
>>
>>
>> https://codereview.chromium.org/2484343002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qyearsley, 2016-11-10 18:37:46]

On 2016/11/10 at 18:28:04, dpranke wrote:
> Thanks, Vince! I thought there was a bug somewhere but I wasn't finding it
> :).
> 
> -- Dirk
> 
> On Thu, Nov 10, 2016 at 10:18 AM, Vince Hang <vhang@google.com> wrote:
> >
> >
> > *** crbug.com/661834 was opened to replace a few webkit bots with Trusty
> > GCE bots.
> >

Alright! So the next step is to commit this and request a master restart for
chromium.webkit, does that sound OK?

[Dirk Pranke, 2016-11-10 18:39:54]

On 2016/11/10 18:37:46, qyearsley wrote:
> Alright! So the next step is to commit this and request a master restart for
> chromium.webkit, does that sound OK?

Once you fix the slave names, yes :)

[qyearsley, 2016-11-11 19:20:19]

On 2016/11/10 at 18:39:54, dpranke wrote:
> On 2016/11/10 18:37:46, qyearsley wrote:
> > Alright! So the next step is to commit this and request a master restart for
> > chromium.webkit, does that sound OK?
> 
> Once you fix the slave names, yes :)

Alright, slaves are now updated so that the Trusty MSAN/ASAN/Leak/dbg builders
are using slave{158..161}-c1.

slave162-c1 and slave163-c1 are unused, and WebKit Linux Trusty is still
slave28-c1, as before. Does that seem right?

[Dirk Pranke, 2016-11-11 22:21:53]

lgtm w/ comment ...

https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json (left):

https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json:290:
"--ninja-ensure-up-to-date",
strange ... any idea why this line changed?

https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
File
scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json
(left):

https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json:390:
"--ninja-ensure-up-to-date",
same here ... maybe you just need to rebase/merge?

[qyearsley, 2016-11-12 00:32:59]

On 2016/11/11 at 22:21:53, dpranke wrote:
> lgtm w/ comment ...
> 
>
https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
> File scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
(left):
> 
>
https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
> scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json:290:
"--ninja-ensure-up-to-date",
> strange ... any idea why this line changed?
> 
>
https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
> File
scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json
(left):
> 
>
https://codereview.chromium.org/2484343002/diff/60001/scripts/slave/recipes/c...
>
scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json:390:
"--ninja-ensure-up-to-date",
> same here ... maybe you just need to rebase/merge?

That is strange -- I tried rebasing but those lines are still being removed, and
I'm not sure why :-/

[qyearsley, 2016-11-14 18:52:37]

https://codereview.chromium.org/2484343002/diff/120001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py (left):

https://codereview.chromium.org/2484343002/diff/120001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py:303:
'chromium_apply_config': ['mb', 'ninja_confirm_noop'],
The reason why the flag "--ninja-ensure-up-to-date" was being removed in some
places was because "ninja_confirm_noop" was in this config here but not in
"WebKit Linux Trusty" below.

It seems like if we want to ensure that the build is up to date on one of these
builders, then we probably want to do so on all of them, so perhaps I should
remove it from all or add it to all -- do you know whether it's necessary?

For this CL, to match the behavior before, it also seems like just adding it to
"WebKit Linux Trusty" seems reasonable.

[qyearsley, 2016-11-14 19:00:09]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 19:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:10:56]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-11-14 20:39:56]

Yes, ninja_confirm_noop should be on everywhere it can be.

[qyearsley, 2016-11-14 21:17:10]

On 2016/11/14 at 20:39:56, dpranke wrote:
> Yes, ninja_confirm_noop should be on everywhere it can be.

Currently there's only one builder on chromium.webkit that has this set in
build/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py -- does it
sound good to make a separate CL to turn it on for the other builders?

[Dirk Pranke, 2016-11-14 21:20:22]

Sure.

[qyearsley, 2016-11-14 21:21:30]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-11-14 21:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2484343002/#ps140001
(title: "Add ninja_confirm_noop and rerun recipe tests")

[commit-bot: I haz the power, 2016-11-14 21:21:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 21:33:02]

Description was changed from

==========
Drop Precise blink builders, add corresponding Trusty builders.

This CL would:

 - Drop "WebKit Linux Precise" from chromium.webkit
 - Replace "WebKit Linux Precise *" with "WebKit Linux Trusty *".
 - Update config in chromium_tests recipe module.

BUG=660580
==========

to

==========
Drop Precise blink builders, add corresponding Trusty builders.

This CL would:

 - Drop "WebKit Linux Precise" from chromium.webkit
 - Replace "WebKit Linux Precise *" with "WebKit Linux Trusty *".
 - Update config in chromium_tests recipe module.

BUG=660580

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/994a2c68356fcde952b4...
==========

[commit-bot: I haz the power, 2016-11-14 21:33:03]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/tools/build/+/994a2c68356fcde952b4...