Drop Precise blink builders on chromium.webkit, add corresponding Trusty builders.

scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from . import steps
 
 SPEC = {
   'settings': {
     'build_gs_bucket': 'chromium-webkit-archive',
     'src_side_runtest_py': False,
@@ skipping 280 matching lines @@
     'testing': {
       'platform': 'mac',
     },
     'enable_swarming': True,
     'swarming_dimensions': {
       'os': 'Mac-10.11',
     },
     'use_isolate': True,
     'checkout_dir': 'mac_layout',
   },
-  'WebKit Linux Precise': {
+  'WebKit Linux Trusty': {
     'chromium_config': 'chromium',
     'chromium_apply_config': ['mb', 'ninja_confirm_noop'],

[qyearsley, 2016/11/14 18:52:37]

The reason why the flag "--ninja-ensure-up-to-date" was being removed in some
places was because "ninja_confirm_noop" was in this config here but not in
"WebKit Linux Trusty" below.

It seems like if we want to ensure that the build is up to date on one of these
builders, then we probably want to do so on all of them, so perhaps I should
remove it from all or add it to all -- do you know whether it's necessary?

For this CL, to match the behavior before, it also seems like just adding it to
"WebKit Linux Trusty" seems reasonable.

     'gclient_config': 'chromium',
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Release',
-      'TARGET_BITS': 64,
-    },
-    'compile_targets': [
-      'blink_tests',
-    ],
-    'tests': [
-      steps.BlinkTest(),
-    ],
-    'testing': {
-      'platform': 'linux',
-    },
-    'enable_swarming': True,
-    'use_isolate': True,
-    'checkout_dir': 'linux_layout',
-  },
-  'WebKit Linux Trusty': {
-    'chromium_config': 'chromium',
-    'chromium_apply_config': ['mb'],
-    'gclient_config': 'chromium',
-    'chromium_config_kwargs': {
-      'BUILD_CONFIG': 'Release',
       'TARGET_BITS': 64,
     },
     'compile_targets': [
       'blink_tests',
     ],
     'tests': [
       steps.BlinkTest(),
     ],
     'testing': {
       'platform': 'linux',
     },
     'enable_swarming': True,
     'use_isolate': True,
     'checkout_dir': 'linux_layout',
   },
-  'WebKit Linux Precise ASAN': {
+  'WebKit Linux Trusty ASAN': {
     'chromium_config': 'chromium_clang',
     'chromium_apply_config': ['asan', 'mb'],
     'gclient_config': 'chromium',
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Release',
       'TARGET_BITS': 64,
     },
     'tests': [
       steps.BlinkTest(extra_args=[
           '--additional-expectations',
           'src/third_party/WebKit/LayoutTests/ASANExpectations',
           # ASAN is roughly 8x slower than Release.
           '--time-out-ms', '48000',
           '--options=--enable-sanitizer',
       ]),
     ],
     'testing': {
       'platform': 'linux',
     },
     'enable_swarming': True,
     'use_isolate': True,
     'checkout_dir': 'linux_layout',
   },
-  'WebKit Linux Precise MSAN': {
+  'WebKit Linux Trusty MSAN': {
     'chromium_config': 'chromium_clang',
     'gclient_config': 'chromium',
     'chromium_apply_config': [
       'mb',
       'msan',
       'msan_full_origin_tracking',
       'prebuilt_instrumented_libraries',
     ],
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Release',
       'TARGET_BITS': 64,
     },
     'tests': [
       steps.BlinkTest(extra_args=[
           '--additional-expectations',
           'src/third_party/WebKit/LayoutTests/MSANExpectations',
           # Because JS code is run on a simulator, the slowdown in JS-heavy
           # tests will be much higher than MSan's average of 3x.
           '--time-out-ms', '66000',
           '--options=--enable-sanitizer',
       ]),
     ],
     'testing': {
       'platform': 'linux',
     },
     'enable_swarming': True,
     'use_isolate': True,
     'checkout_dir': 'linux_layout',
   },
-  'WebKit Linux Precise (dbg)': {
+  'WebKit Linux Trusty (dbg)': {
     'chromium_config': 'chromium',
     'chromium_apply_config': ['mb'],
     'gclient_config': 'chromium',
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Debug',
       'TARGET_BITS': 64,
     },
     'tests': [
       steps.BlinkTest(),
     ],
@@ skipping 36 matching lines @@
     'root_devices': True,
     'tests': [
       steps.GTestTest('blink_heap_unittests'),
       steps.GTestTest('webkit_unit_tests'),
       steps.BlinkTest(),
     ],
     'testing': {
       'platform': 'linux',
     },
   },
-  'WebKit Linux Precise Leak': {
+  'WebKit Linux Trusty Leak': {
     'chromium_config': 'chromium',
     'chromium_apply_config': ['mb'],
     'gclient_config': 'chromium',
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Release',
       'TARGET_BITS': 64,
     },
     'compile_targets': [
       'blink_tests',
     ],
     'tests': [
       steps.BlinkTest(extra_args=[
           '--additional-expectations',
           'src/third_party/WebKit/LayoutTests/LeakExpectations',
           '--options=--enable-leak-detection',
       ]),
     ],
     'testing': {
       'platform': 'linux',
     },
     'enable_swarming': True,
     'use_isolate': True,
   },
 }