chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 2484293003: Use only renderer driven offsets for fullscreen state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2484293003: Use only renderer driven offsets for fullscreen state. (Closed)

Patch Set: Partially disable testControlsShownOnUnresponsiveRenderer due to timing issues with renderer logic … Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index 1a9c547a13fff4e9917f8edde74c23f869ab64b5..7a35c67a8ce7a90cbdfc875aec890b77f31d55d4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -30,7 +30,6 @@ import org.chromium.blink_public.platform.WebDisplayMode;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.TabState;

import org.chromium.chrome.browser.document.DocumentUtils;

-import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;

import org.chromium.chrome.browser.metrics.WebappUma;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

@@ -38,7 +37,6 @@ import org.chromium.chrome.browser.tab.TabDelegateFactory;

import org.chromium.chrome.browser.tab.TabObserver;

import org.chromium.chrome.browser.util.ColorUtils;

import org.chromium.chrome.browser.util.UrlUtilities;

-import org.chromium.chrome.browser.widget.ControlContainer;

import org.chromium.content.browser.ScreenOrientationProvider;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.net.NetworkChangeNotifier;

@@ -571,14 +569,6 @@ public class WebappActivity extends FullScreenActivity {

}

@Override

- protected ChromeFullscreenManager createFullscreenManager() {

- return new ChromeFullscreenManager(this,

- (ControlContainer) findViewById(R.id.control_container),

- getTabModelSelector(), getControlContainerHeightResource(),

- false /* supportsBrowserOverride */, false /* isBottomControls */);

- }

- @Override

public int getControlContainerHeightResource() {

return R.dimen.webapp_control_container_height;

}