chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java - Issue 2484293003: Use only renderer driven offsets for fullscreen state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

Issue 2484293003: Use only renderer driven offsets for fullscreen state. (Closed)

Patch Set: Partially disable testControlsShownOnUnresponsiveRenderer due to timing issues with renderer logic … Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

index f8fa6cc2d27771b3fd6fd45302444264cd5435bd..f590ec131a05c83cf9aa2eb5e55f0744b27d724e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

@@ -10,6 +10,7 @@ import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabContextMenuItemDelegate;

import org.chromium.chrome.browser.tab.TabDelegateFactory;

+import org.chromium.chrome.browser.tab.TabStateBrowserControlsVisibilityDelegate;

/**

* A {@link TabDelegateFactory} class to be used in all {@link Tab} instances owned

@@ -24,7 +25,7 @@ public class FullScreenDelegateFactory extends TabDelegateFactory {

@Override

public BrowserControlsVisibilityDelegate createBrowserControlsVisibilityDelegate(Tab tab) {

- return new BrowserControlsVisibilityDelegate(tab) {

+ return new TabStateBrowserControlsVisibilityDelegate(tab) {

@Override

public boolean isHidingBrowserControlsEnabled() {

return !isShowingBrowserControlsEnabled();