Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: third_party/WebKit/Source/core/style/ClipPathOperation.cpp

Issue 2484153003: Use an SVGElementProxy in ReferenceClipPathOperation (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ClipPathOperation.cpp
diff --git a/third_party/WebKit/Source/core/style/ClipPathOperation.cpp b/third_party/WebKit/Source/core/style/ClipPathOperation.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..0ea721d510ec51c722779f0cafe8e1c7b5958ee7
--- /dev/null
+++ b/third_party/WebKit/Source/core/style/ClipPathOperation.cpp
@@ -0,0 +1,24 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/style/ClipPathOperation.h"
+
+namespace blink {
+
+void ReferenceClipPathOperation::addClient(SVGResourceClient* client) {
+ m_elementProxy->addClient(client);
chrishtr 2016/11/14 20:56:13 Why have these helper methods if elementProxy() is
fs 2016/11/15 14:10:56 I guess I thought it looked prettier... (I did thi
chrishtr 2016/11/15 16:24:22 Maybe. I don't feel that strongly about it or my o
fs 2016/11/15 16:29:32 Noted. I've dropped the accessor (elementProxy())
+}
+
+void ReferenceClipPathOperation::removeClient(SVGResourceClient* client) {
+ m_elementProxy->removeClient(client);
+}
+
+bool ReferenceClipPathOperation::operator==(const ClipPathOperation& o) const {
+ if (!isSameType(o))
+ return false;
+ const ReferenceClipPathOperation& other = toReferenceClipPathOperation(o);
+ return m_elementProxy == other.m_elementProxy && m_url == other.m_url;
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698