Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: third_party/WebKit/Source/core/style/ClipPathOperation.cpp

Issue 2484153003: Use an SVGElementProxy in ReferenceClipPathOperation (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "core/style/ClipPathOperation.h"
6
7 namespace blink {
8
9 void ReferenceClipPathOperation::addClient(SVGResourceClient* client) {
10 m_elementProxy->addClient(client);
chrishtr 2016/11/14 20:56:13 Why have these helper methods if elementProxy() is
fs 2016/11/15 14:10:56 I guess I thought it looked prettier... (I did thi
chrishtr 2016/11/15 16:24:22 Maybe. I don't feel that strongly about it or my o
fs 2016/11/15 16:29:32 Noted. I've dropped the accessor (elementProxy())
11 }
12
13 void ReferenceClipPathOperation::removeClient(SVGResourceClient* client) {
14 m_elementProxy->removeClient(client);
15 }
16
17 bool ReferenceClipPathOperation::operator==(const ClipPathOperation& o) const {
18 if (!isSameType(o))
19 return false;
20 const ReferenceClipPathOperation& other = toReferenceClipPathOperation(o);
21 return m_elementProxy == other.m_elementProxy && m_url == other.m_url;
22 }
23
24 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698