Use an SVGElementProxy in ReferenceClipPathOperation

third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index d7f165302bd2963fe4db136bad08c947a0ca1f09..b55d04f2cc225d951ed21cc130661b1bd3fed1fc 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -138,17 +138,12 @@ PassRefPtr<ClipPathOperation> StyleBuilderConverter::convertClipPath(
   if (value.isBasicShapeValue())
     return ShapeClipPathOperation::create(basicShapeForValue(state, value));
   if (value.isURIValue()) {
-    SVGURLReferenceResolver resolver(toCSSURIValue(value).value(),
-                                     state.document());
-    // If the reference is non-local, then the fragment will remain as a
-    // null string, which makes the element lookup fail.
-    AtomicString fragmentIdentifier;
-    if (resolver.isLocal())
-      fragmentIdentifier = resolver.fragmentIdentifier();
+    const CSSURIValue& urlValue = toCSSURIValue(value);
+    SVGElementProxy& elementProxy =
+        state.elementStyleResources().cachedOrPendingFromValue(urlValue);
     // TODO(fs): Doesn't work with forward or external SVG references

[pdr., 2016/11/15 04:14:35]

I think the new id tracking technology may fix this. Is this TODO (and the one
in ClipPathClipper.cpp) still needed with this patch?

[fs, 2016/11/15 14:10:56]

I think the bit about 'forward' should be fixed, but I haven't dug into these
bugs to see what exactly they were about. (The crbug.com/391604 reference should
obviously be removed, so I'll do that =).)

The 'external' bit (crbug.com/109212) should still be true (for 'clip-path'.)

(Ended up removing mentions of "forward", and updated to reference
crbug.com/109212 in both cases.)

     // (crbug.com/391604, crbug.com/109212, ...)
-    return ReferenceClipPathOperation::create(toCSSURIValue(value).value(),
-                                              fragmentIdentifier);
+    return ReferenceClipPathOperation::create(urlValue.value(), elementProxy);
   }
   DCHECK(value.isIdentifierValue() &&
          toCSSIdentifierValue(value).getValueID() == CSSValueNone);