fpdfsdk/fpdf_flatten.cpp - Issue 2484033002: Return unique_ptr from CPDF_Object::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdf_flatten.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)

Patch Set: std::move() it Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdf_flatten.cpp

diff --git a/fpdfsdk/fpdf_flatten.cpp b/fpdfsdk/fpdf_flatten.cpp

index 6cffbe0b3120dd2490ff89fe41808711f2e701c3..f39a50aad4b73728aff34ab281c7290ae0f24e56 100644

--- a/fpdfsdk/fpdf_flatten.cpp

+++ b/fpdfsdk/fpdf_flatten.cpp

@@ -408,8 +408,9 @@ DLLEXPORT int STDCALL FPDFPage_Flatten(FPDF_PAGE page, int nFlag) {

CPDF_Object* pObj = pAPStream;

if (pObj->IsInline()) {

- pObj = pObj->Clone();

- pDocument->AddIndirectObject(pObj);

+ std::unique_ptr<CPDF_Object> pNew = pObj->Clone();

+ pObj = pNew.get();

+ pDocument->AddIndirectObject(pNew.release());

}

CPDF_Dictionary* pObjDic = pObj->GetDict();

« no previous file with comments | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »