Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: core/fpdfdoc/cpvt_generateap.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfdoc/cpdf_interform.cpp ('k') | fpdfsdk/fpdf_flatten.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfdoc/cpvt_generateap.cpp
diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp
index 66abde63a869c9251c857c94e1fe1086ed733d8e..93ef9dc3660fcf3b1790fd5e358ae9c605c36dcf 100644
--- a/core/fpdfdoc/cpvt_generateap.cpp
+++ b/core/fpdfdoc/cpvt_generateap.cpp
@@ -186,7 +186,8 @@ bool GenerateWidgetAP(CPDF_Document* pDoc,
pStreamResFontList->SetReferenceFor(sFontName, pDoc,
pFontDict->GetObjNum());
} else {
- pStreamDict->SetFor("Resources", pFormDict->GetDictFor("DR")->Clone());
+ pStreamDict->SetFor("Resources",
+ pFormDict->GetDictFor("DR")->Clone().release());
pStreamResList = pStreamDict->GetDictFor("Resources");
}
}
@@ -437,7 +438,8 @@ bool GenerateWidgetAP(CPDF_Document* pDoc,
pStreamResFontList->SetReferenceFor(sFontName, pDoc,
pFontDict->GetObjNum());
} else {
- pStreamDict->SetFor("Resources", pFormDict->GetDictFor("DR")->Clone());
+ pStreamDict->SetFor("Resources",
+ pFormDict->GetDictFor("DR")->Clone().release());
pStreamResList = pStreamDict->GetDictFor("Resources");
}
}
« no previous file with comments | « core/fpdfdoc/cpdf_interform.cpp ('k') | fpdfsdk/fpdf_flatten.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698