core/fpdfapi/parser/cpdf_boolean.h - Issue 2484033002: Return unique_ptr from CPDF_Object::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_boolean.h

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)

Patch Set: std::move() it Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_boolean.h

diff --git a/core/fpdfapi/parser/cpdf_boolean.h b/core/fpdfapi/parser/cpdf_boolean.h

index bc864a6ab8599f2b09d955eeeaa87d36323c15ac..808f9ee6f019026ed386ed8ce4a5d7f50f5b1e15 100644

--- a/core/fpdfapi/parser/cpdf_boolean.h

+++ b/core/fpdfapi/parser/cpdf_boolean.h

@@ -19,7 +19,7 @@ class CPDF_Boolean : public CPDF_Object {

// CPDF_Object:

Type GetType() const override;

- CPDF_Object* Clone() const override;

+ std::unique_ptr<CPDF_Object> Clone() const override;

CFX_ByteString GetString() const override;

int GetInteger() const override;

void SetString(const CFX_ByteString& str) override;

« no previous file with comments | « core/fpdfapi/parser/cpdf_array_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_boolean.cpp » ('j') | no next file with comments »