Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: core/fpdfapi/parser/cpdf_boolean.h

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)
Patch Set: std::move() it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_array_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_boolean.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_ 7 #ifndef CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_
8 #define CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_ 8 #define CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_
9 9
10 #include "core/fpdfapi/parser/cpdf_object.h" 10 #include "core/fpdfapi/parser/cpdf_object.h"
11 #include "core/fxcrt/fx_string.h" 11 #include "core/fxcrt/fx_string.h"
12 #include "core/fxcrt/fx_system.h" 12 #include "core/fxcrt/fx_system.h"
13 13
14 class CPDF_Boolean : public CPDF_Object { 14 class CPDF_Boolean : public CPDF_Object {
15 public: 15 public:
16 CPDF_Boolean(); 16 CPDF_Boolean();
17 explicit CPDF_Boolean(bool value); 17 explicit CPDF_Boolean(bool value);
18 ~CPDF_Boolean() override; 18 ~CPDF_Boolean() override;
19 19
20 // CPDF_Object: 20 // CPDF_Object:
21 Type GetType() const override; 21 Type GetType() const override;
22 CPDF_Object* Clone() const override; 22 std::unique_ptr<CPDF_Object> Clone() const override;
23 CFX_ByteString GetString() const override; 23 CFX_ByteString GetString() const override;
24 int GetInteger() const override; 24 int GetInteger() const override;
25 void SetString(const CFX_ByteString& str) override; 25 void SetString(const CFX_ByteString& str) override;
26 bool IsBoolean() const override; 26 bool IsBoolean() const override;
27 CPDF_Boolean* AsBoolean() override; 27 CPDF_Boolean* AsBoolean() override;
28 const CPDF_Boolean* AsBoolean() const override; 28 const CPDF_Boolean* AsBoolean() const override;
29 29
30 protected: 30 protected:
31 bool m_bValue; 31 bool m_bValue;
32 }; 32 };
33 33
34 inline CPDF_Boolean* ToBoolean(CPDF_Object* obj) { 34 inline CPDF_Boolean* ToBoolean(CPDF_Object* obj) {
35 return obj ? obj->AsBoolean() : nullptr; 35 return obj ? obj->AsBoolean() : nullptr;
36 } 36 }
37 37
38 inline const CPDF_Boolean* ToBoolean(const CPDF_Object* obj) { 38 inline const CPDF_Boolean* ToBoolean(const CPDF_Object* obj) {
39 return obj ? obj->AsBoolean() : nullptr; 39 return obj ? obj->AsBoolean() : nullptr;
40 } 40 }
41 41
42 #endif // CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_ 42 #endif // CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_array_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_boolean.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698