core/fpdfapi/page/cpdf_contentmarkitem.cpp - Issue 2484033002: Return unique_ptr from CPDF_Object::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_contentmarkitem.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)

Patch Set: std::move() it Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_contentmarkitem.cpp

diff --git a/core/fpdfapi/page/cpdf_contentmarkitem.cpp b/core/fpdfapi/page/cpdf_contentmarkitem.cpp

index dffeada707582f33ea90134e8e775ae1a50937ae..48a96792515eec3d68ede6f5776f6d50ebd9de05 100644

--- a/core/fpdfapi/page/cpdf_contentmarkitem.cpp

+++ b/core/fpdfapi/page/cpdf_contentmarkitem.cpp

@@ -16,7 +16,7 @@ CPDF_ContentMarkItem::CPDF_ContentMarkItem(const CPDF_ContentMarkItem& that)

m_ParamType(that.m_ParamType),

m_pPropertiesDict(that.m_pPropertiesDict) {

if (that.m_pDirectDict)

- m_pDirectDict.reset(that.m_pDirectDict->Clone()->AsDictionary());

+ m_pDirectDict = ToDictionary(that.m_pDirectDict->Clone());

}

CPDF_ContentMarkItem::~CPDF_ContentMarkItem() {}