core/fpdfapi/page/cpdf_streamcontentparser.cpp - Issue 2484033002: Return unique_ptr from CPDF_Object::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_streamcontentparser.cpp

Issue 2484033002: Return unique_ptr from CPDF_Object::Clone(). (Closed)

Patch Set: std::move() it Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_streamcontentparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.cpp b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

index cd77c0b6330640ae7b4afbbeafb6fa52970ca33d..e7d23c0522a664d20f2ca322c6f0230e4c6ccfd5 100644

--- a/core/fpdfapi/page/cpdf_streamcontentparser.cpp

+++ b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

@@ -667,7 +667,7 @@ void CPDF_StreamContentParser::Handle_BeginImage() {

if (name != "DeviceRGB" && name != "DeviceGray" && name != "DeviceCMYK") {

pCSObj = FindResourceObj("ColorSpace", name);

if (pCSObj && pCSObj->IsInline()) {

- pCSObj = pCSObj->Clone();

+ pCSObj = pCSObj->Clone().release();

pDict->SetFor("ColorSpace", pCSObj);

}

« no previous file with comments | « core/fpdfapi/page/cpdf_contentmarkitem.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »