Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2483853004: [Devtools] Renamed Network's Timeline to Waterfall (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Renamed Network's Timeline to Waterfall This patch renames all references of network's timeline to waterfall. This should help with reducing the name conflict of Timeline vs Network's timeline. R=dgozman,lushnikov BUG=653738 Committed: https://crrev.com/3e197537ed66cb01d433ace38c8988e1ccb0f34d Cr-Commit-Position: refs/heads/master@{#430769}

Patch Set 1 #

Patch Set 2 : [Devtools] Renamed Network's Timeline to Waterfall #

Messages

Total messages: 12 (7 generated)
allada
PTL
4 years, 1 month ago (2016-11-08 02:32:14 UTC) #2
lushnikov
rs lgtm, I poke randomly into different parts of this CL and it seemed reasonable
4 years, 1 month ago (2016-11-08 02:47:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483853004/20001
4 years, 1 month ago (2016-11-08 21:41:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 23:49:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:55:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e197537ed66cb01d433ace38c8988e1ccb0f34d
Cr-Commit-Position: refs/heads/master@{#430769}

Powered by Google App Engine
This is Rietveld 408576698