Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2483853004: [Devtools] Renamed Network's Timeline to Waterfall (Closed)
Patch Set: [Devtools] Renamed Network's Timeline to Waterfall Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
similarity index 96%
rename from third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
rename to third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index a3b6a5921c8184adf67a555932cb2d01c9cbb1f9..10e21ac2cf7a6492366a8fb8c3f1a232b875a450 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -4,15 +4,15 @@
/**
* @unrestricted
*/
-WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
+WebInspector.NetworkWaterfallColumn = class extends WebInspector.VBox {
/**
* @param {number} rowHeight
* @param {!WebInspector.NetworkTimeCalculator} calculator
*/
constructor(rowHeight, calculator) {
- // TODO(allada) Make this a shadowDOM when the NetworkTimelineColumn gets moved into NetworkLogViewColumns.
+ // TODO(allada) Make this a shadowDOM when the NetworkWaterfallColumn gets moved into NetworkLogViewColumns.
super(false);
- this.registerRequiredCSS('network/networkTimelineColumn.css');
+ this.registerRequiredCSS('network/networkWaterfallColumn.css');
this._canvas = this.contentElement.createChild('canvas');
this._canvas.tabIndex = 1;
@@ -185,7 +185,7 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
/**
* @param {number=} scrollTop
* @param {!Map<string, !Array<number>>=} eventDividers
- * @param {!WebInspector.NetworkTimelineColumn.RequestData=} requestData
+ * @param {!WebInspector.NetworkWaterfallColumn.RequestData=} requestData
*/
update(scrollTop, eventDividers, requestData) {
if (scrollTop !== undefined)
@@ -324,7 +324,7 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
/**
* @return {number}
*/
- _timelineDuration() {
+ _waterfallDuration() {
return this._calculator.maximumBoundary() - this._calculator.minimumBoundary();
}
@@ -356,7 +356,7 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
var resourceType = request.resourceType();
if (this._borderColorsForResourceTypeCache.has(resourceType))
return this._borderColorsForResourceTypeCache.get(resourceType);
- var colorsForResourceType = WebInspector.NetworkTimelineColumn._colorsForResourceType;
+ var colorsForResourceType = WebInspector.NetworkWaterfallColumn._colorsForResourceType;
var color = colorsForResourceType[resourceType] || colorsForResourceType.Other;
var parsedColor = WebInspector.Color.parse(color);
var hsla = parsedColor.hsla();
@@ -373,7 +373,7 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
* @return {string|!CanvasGradient}
*/
_colorForResourceType(context, request) {
- var colorsForResourceType = WebInspector.NetworkTimelineColumn._colorsForResourceType;
+ var colorsForResourceType = WebInspector.NetworkWaterfallColumn._colorsForResourceType;
var resourceType = request.resourceType();
var color = colorsForResourceType[resourceType] || colorsForResourceType.Other;
if (request.cached())
@@ -584,7 +584,7 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
/**
* @return {string}
- * @this {WebInspector.NetworkTimelineColumn}
+ * @this {WebInspector.NetworkWaterfallColumn}
*/
function getRowColor() {
if (this._hoveredRequest === request)
@@ -607,9 +607,9 @@ WebInspector.NetworkTimelineColumn = class extends WebInspector.VBox {
/**
* @typedef {{requests: !Array<!WebInspector.NetworkRequest>, navigationRequest: ?WebInspector.NetworkRequest}}
*/
-WebInspector.NetworkTimelineColumn.RequestData;
+WebInspector.NetworkWaterfallColumn.RequestData;
-WebInspector.NetworkTimelineColumn._colorsForResourceType = {
+WebInspector.NetworkWaterfallColumn._colorsForResourceType = {
document: 'hsl(215, 100%, 80%)',
font: 'hsl(8, 100%, 80%)',
media: 'hsl(272, 64%, 80%)',

Powered by Google App Engine
This is Rietveld 408576698