gn: Diag on distinct toolchains with the same name.

gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same output
directory and clobber each others generated .ninja files.  After this patch, this still
happens, but gn writes an error message while writing the final build.ninja file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
Committed: https://crrev.com/eab6e2d58dc3b71e094ff58d822980ca3473caf8
Cr-Commit-Position: refs/heads/master@{#430473}

[Nico, 2016-11-06 23:06:46]

Description was changed from

==========
gn: Diag on distinct toolchains with the same name.

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

to

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This is can often be fixed by making sure that distinct toolchains
have distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

[Nico, 2016-11-06 23:07:12]

Description was changed from

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This is can often be fixed by making sure that distinct toolchains
have distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

to

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This is can often be fixed by making sure that distinct toolchains
have distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

[Nico, 2016-11-06 23:10:32]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2016-11-07 18:24:59]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-07 18:25:00]

lgtm, but brettw@ should review.

[brettw, 2016-11-07 19:22:36]

lgtm

https://codereview.chromium.org/2483713003/diff/40001/tools/gn/ninja_build_wr...
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/2483713003/diff/40001/tools/gn/ninja_build_wr...
tools/gn/ninja_build_writer.cc:141: "This is can often be fixed by making sure
that distinct toolchains\n"
"is can often" -> "can"

[Nico, 2016-11-07 23:54:57]

Description was changed from

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This is can often be fixed by making sure that distinct toolchains
have distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

to

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

[Nico, 2016-11-08 00:00:40]

thanks!

https://codereview.chromium.org/2483713003/diff/40001/tools/gn/ninja_build_wr...
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/2483713003/diff/40001/tools/gn/ninja_build_wr...
tools/gn/ninja_build_writer.cc:141: "This is can often be fixed by making sure
that distinct toolchains\n"
On 2016/11/07 19:22:36, brettw (ping on IM after 24h) wrote:
> "is can often" -> "can"

Done.

[Nico, 2016-11-08 00:00:43]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-11-08 00:00:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2483713003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-08 00:01:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:15:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2016-11-08 01:29:17]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-11-08 01:29:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2483713003/#ps100001
(title: "lol msvc")

[commit-bot: I haz the power, 2016-11-08 01:30:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:45:29]

Description was changed from

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

to

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

[commit-bot: I haz the power, 2016-11-08 01:45:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-08 01:57:24]

Description was changed from

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054
==========

to

==========
gn: Diag on distinct toolchains with the same name.

Previously, toolchains with the same name used to silently write to the same
output
directory and clobber each others generated .ninja files.  After this patch,
this still
happens, but gn writes an error message while writing the final build.ninja
file.

Example output:
ERROR at //build/toolchain/mac2/BUILD.gn:51:3: Duplicate toolchain.
  toolchain(target_name) {
  ^-----------------------
Two or more toolchains write to the same directory:
  //out/gn1/clang_x64/

This can be fixed by making sure that distinct toolchains have
distinct names.

See //build/toolchain/mac3/BUILD.gn:51:3: Previous toolchain.
  toolchain(target_name) {
  ^-----------------------

Depends on https://codereview.chromium.org/2485523002/

BUG=661054

Committed: https://crrev.com/eab6e2d58dc3b71e094ff58d822980ca3473caf8
Cr-Commit-Position: refs/heads/master@{#430473}
==========

[commit-bot: I haz the power, 2016-11-08 01:57:25]

Patchset 6 (id:??) landed as
https://crrev.com/eab6e2d58dc3b71e094ff58d822980ca3473caf8
Cr-Commit-Position: refs/heads/master@{#430473}