Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/gn/ninja_build_writer.h

Issue 2483713003: gn: Diag on distinct toolchains with the same name. (Closed)
Patch Set: lol msvc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.h
diff --git a/tools/gn/ninja_build_writer.h b/tools/gn/ninja_build_writer.h
index 530ac7189035cea75d46c0a36fcdc983dfde6c13..51535aabf76ca16f9d5b6d1c5869a2b9638a4f80 100644
--- a/tools/gn/ninja_build_writer.h
+++ b/tools/gn/ninja_build_writer.h
@@ -49,9 +49,8 @@ class NinjaBuildWriter {
private:
void WriteNinjaRules();
void WriteAllPools();
- void WriteSubninjas();
- bool WritePhonyAndAllRules(
- Err* err);
+ bool WriteSubninjas(Err* err);
+ bool WritePhonyAndAllRules(Err* err);
void WritePhonyRule(const Target* target, const std::string& phony_name);
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698