third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html - Issue 2483703002: Replicate feature policy headers to remote frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

Issue 2483703002: Replicate feature policy headers to remote frames (Closed)

Patch Set: Get replication actually working; add layout tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php ('K') | « third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php ('k') | third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-enabled.html » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html b/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

similarity index 63%

copy from third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html

copy to third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

index d5b3f8f5884276bac569c963d3daa4fdbb5c6580..38f0fdf0cf383ee63c4f85b1cda77960852f8104 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html

+++ b/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

@@ -7,8 +7,8 @@

<body>

test(function () {

- assert_true(navigator.vibrate(200));

- }, "A same-origin iframe may call navigator.vibrate.");

+ assert_false("write" in document);

alexmos 2016/11/09 01:16:55 Looks like the test is failing without --site-per-

iclelland 2016/11/09 18:07:59 Thanks for the pointer -- I'll definitely do that

+ }, "A frame with docwrite disabled by policy should not see document.write");

</script>

</body>

</html>