third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html - Issue 2483703002: Replicate feature policy headers to remote frames

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-disabled.html

Issue 2483703002: Replicate feature policy headers to remote frames (Closed)

Patch Set: Get replication actually working; add layout tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php ('K') | « third_party/WebKit/LayoutTests/http/tests/feature-policy/cross-origin-feature-disabled.php ('k') | third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/cross-origin-iframe-for-feature-enabled.html » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/resources/testharness.js"></script>	4 <script src="/resources/testharness.js"></script>

5 <script src="/resources/testharnessreport.js"></script>	5 <script src="/resources/testharnessreport.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <script>	8 <script>

9 test(function () {	9 test(function () {

10 assert_true(navigator.vibrate(200));	10 assert_false("write" in document);
	alexmos 2016/11/09 01:16:55 Looks like the test is failing without --site-per- Looks like the test is failing without --site-per-process, and crashing with it. The crash seems to be in BlinkTestController::OnLayoutDumpResponse - if you need any help with that, you can ping lukasza@, who worked on OOPIF support for layout test harness. iclelland 2016/11/09 18:07:59 Thanks for the pointer -- I'll definitely do that Show quoted text On 2016/11/09 01:16:55, alexmos wrote: > Looks like the test is failing without --site-per-process, and crashing with it. > > The crash seems to be in BlinkTestController::OnLayoutDumpResponse - if you need > any help with that, you can ping lukasza@, who worked on OOPIF support for > layout test harness. Thanks for the pointer -- I'll definitely do that if I can't get the tests working soon.
11 }, "A same-origin iframe may call navigator.vibrate.");	11 }, "A frame with docwrite disabled by policy should not see document.wri te");

12 </script>	12 </script>

13 </body>	13 </body>

14 </html>	14 </html>

OLD	NEW