Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2483673002: Clean up link references in //tools/gn/README.md. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up link references in //tools/gn/README.md. Before Gitiles bug 82 was fixed, Gitiles did not render relative URLs correctly on branches, so the GN docs had hard-coded absolute URLs. That bug is now fixed, so this updates the docs. R=brettw@chromium.org Committed: https://crrev.com/44dbd2f12ae5d6307b607f18fe2dd466d8a8fa38 Cr-Commit-Position: refs/heads/master@{#439388}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review feedback, merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tools/gn/README.md View 1 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
4 years, 1 month ago (2016-11-05 21:38:10 UTC) #1
Dirk Pranke
ping?
4 years, 1 month ago (2016-11-17 23:54:16 UTC) #2
brettw
lgtm https://codereview.chromium.org/2483673002/diff/1/tools/gn/README.md File tools/gn/README.md (right): https://codereview.chromium.org/2483673002/diff/1/tools/gn/README.md#newcode41 tools/gn/README.md:41: * [GYP conversion cookbook](docs/cookbook.md) Delete this link to ...
4 years, 1 month ago (2016-11-18 21:09:52 UTC) #3
Dirk Pranke
https://codereview.chromium.org/2483673002/diff/1/tools/gn/README.md File tools/gn/README.md (right): https://codereview.chromium.org/2483673002/diff/1/tools/gn/README.md#newcode41 tools/gn/README.md:41: * [GYP conversion cookbook](docs/cookbook.md) On 2016/11/18 21:09:52, brettw (ping ...
4 years, 1 month ago (2016-11-18 21:14:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483673002/20001
4 years ago (2016-12-19 00:15:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 00:25:10 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 00:27:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44dbd2f12ae5d6307b607f18fe2dd466d8a8fa38
Cr-Commit-Position: refs/heads/master@{#439388}

Powered by Google App Engine
This is Rietveld 408576698