Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2483653002: Update ash DOM agent so that widgets are direct children of windows (Closed)

Created:
4 years, 1 month ago by Sarmad Hashmi
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ash DOM agent so that widgets are direct children of windows Small bug that caused widgets to be the siblings of their parent windows. This fixes that by adding any widgets as the direct descendents of their parent windows. In addition, modified the tests so that they compare all windows to nodes. Removed the widget finding method as they can now be queried directly from the window nodes (first child should be the widget). BUG=648701 Committed: https://crrev.com/810a7a208ae6566e497fd3412b3a6da885234d0a Cr-Commit-Position: refs/heads/master@{#431469}

Patch Set 1 #

Patch Set 2 : no change #

Patch Set 3 : Update ash DOM agent so that widgets are direct children of windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M ash/common/devtools/ash_devtools_dom_agent.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 1 2 6 chunks +22 lines, -27 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
Sarmad Hashmi
4 years, 1 month ago (2016-11-07 18:47:58 UTC) #6
sadrul
lgtm
4 years, 1 month ago (2016-11-08 02:01:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483653002/40001
4 years, 1 month ago (2016-11-11 01:59:38 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 02:35:21 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:46:21 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/810a7a208ae6566e497fd3412b3a6da885234d0a
Cr-Commit-Position: refs/heads/master@{#431469}

Powered by Google App Engine
This is Rietveld 408576698