Add tests for ash devtools window updates

Add tests for ash devtools window updates

Add tests for when a window is added, removed, reorganized and when a
stacking change occurs.

BUG=648701
Committed: https://crrev.com/90cb9ea6f9d7605422477edf45a4a1f54de1beea
Cr-Commit-Position: refs/heads/master@{#431454}

[Sarmad Hashmi, 2016-11-04 07:04:49]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 07:04:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-04 07:05:06]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-04 07:05:07]

PTAL sadrul@

[commit-bot: I haz the power, 2016-11-04 08:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:51:28]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-04 16:54:29]

Removed use of gmock.

[Sarmad Hashmi, 2016-11-04 16:54:51]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:30:48]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Sarmad Hashmi, 2016-11-04 21:55:24]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:26:53]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-08 01:58:33]

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:17: Array<DOM::Node>*
default_children = nullptr;
Why does this need to be a global variable? Can this be something
AshDevToolsTest owns instead?

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:34: void sendProtocolResponse(int
callId, const std::string& message) override{};
space after override.
no ; at the end

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:35: void
flushProtocolNotifications() override{};
ditto

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:49: int
CountProtocolNotificationMessage(const std::string& message) {
Non-overrides before overrides.

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:56: };
DISALLOW_COPY_AND_ASSIGN

[Sarmad Hashmi, 2016-11-08 16:51:06]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 16:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-08 16:51:47]

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:17: Array<DOM::Node>*
default_children = nullptr;
On 2016/11/08 01:58:33, sadrul wrote:
> Why does this need to be a global variable? Can this be something
> AshDevToolsTest owns instead?

Done.

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:34: void sendProtocolResponse(int
callId, const std::string& message) override{};
On 2016/11/08 01:58:33, sadrul wrote:
> space after override.
> no ; at the end

Done.

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:35: void
flushProtocolNotifications() override{};
On 2016/11/08 01:58:33, sadrul wrote:
> ditto

Done.

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:49: int
CountProtocolNotificationMessage(const std::string& message) {
On 2016/11/08 01:58:33, sadrul wrote:
> Non-overrides before overrides.

Done.

https://codereview.chromium.org/2480683003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:56: };
On 2016/11/08 01:58:33, sadrul wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[commit-bot: I haz the power, 2016-11-08 17:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 17:07:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sarmad Hashmi, 2016-11-08 17:41:47]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 17:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:43:07]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-08 22:31:30]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:58:49]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-09 15:50:24]

https://codereview.chromium.org/2480683003/diff/120001/ash/common/devtools/as...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2480683003/diff/120001/ash/common/devtools/as...
ash/common/devtools/ash_devtools_unittest.cc:199:
ASSERT_TRUE(parent_node->getChildren(default_children));
Looking more at the usage of |default_children|, can it just be removed? And use
nullptr instead?

[Sarmad Hashmi, 2016-11-09 17:10:12]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 17:10:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-09 17:10:40]

https://codereview.chromium.org/2480683003/diff/120001/ash/common/devtools/as...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2480683003/diff/120001/ash/common/devtools/as...
ash/common/devtools/ash_devtools_unittest.cc:199:
ASSERT_TRUE(parent_node->getChildren(default_children));
On 2016/11/09 15:50:24, sadrul wrote:
> Looking more at the usage of |default_children|, can it just be removed? And
use
> nullptr instead?

Done.

[commit-bot: I haz the power, 2016-11-09 18:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 18:13:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sadrul, 2016-11-10 20:11:41]

lgtm

https://codereview.chromium.org/2480683003/diff/140001/ash/common/devtools/as...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2480683003/diff/140001/ash/common/devtools/as...
ash/common/devtools/ash_devtools_unittest.cc:32: FakeFrontendChannel(){};
space after (). no ; at the end

You probably need a dtor as well?

[Sarmad Hashmi, 2016-11-10 21:35:42]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 21:36:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:39:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Sarmad Hashmi, 2016-11-10 22:07:00]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 22:11:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sarmad Hashmi, 2016-11-11 01:30:55]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 01:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:49:46]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-11 01:50:07]

The CQ bit was checked by mhashmi@chromium.org

[Sarmad Hashmi, 2016-11-11 01:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2480683003/#ps180001
(title: "Add destructor for FakeFrontendChannel")

[commit-bot: I haz the power, 2016-11-11 01:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:56:10]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-11-11 02:01:04]

Description was changed from

==========
Add tests for ash devtools window updates

Add tests for when a window is added, removed, reorganized and when a
stacking change occurs.

BUG=648701
==========

to

==========
Add tests for ash devtools window updates

Add tests for when a window is added, removed, reorganized and when a
stacking change occurs.

BUG=648701

Committed: https://crrev.com/90cb9ea6f9d7605422477edf45a4a1f54de1beea
Cr-Commit-Position: refs/heads/master@{#431454}
==========

[commit-bot: I haz the power, 2016-11-11 02:01:05]

Patchset 10 (id:??) landed as
https://crrev.com/90cb9ea6f9d7605422477edf45a4a1f54de1beea
Cr-Commit-Position: refs/heads/master@{#431454}