Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2483553002: Create cast_shell_lib target for cast_shell and browser tests. (Closed)

Created:
4 years, 1 month ago by alokp
Modified:
4 years, 1 month ago
Reviewers:
slan, Simeon
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create cast_shell_lib target for cast_shell and browser tests. BUG=663067 Committed: https://crrev.com/cd91e603433560ba111846de8ef7da52001a427a Cr-Commit-Position: refs/heads/master@{#431374}

Patch Set 1 #

Patch Set 2 : fixes android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M chromecast/BUILD.gn View 1 2 chunks +7 lines, -17 lines 0 comments Download
M chromecast/android/BUILD.gn View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
alokp
4 years, 1 month ago (2016-11-10 17:40:44 UTC) #9
slan
lgtm
4 years, 1 month ago (2016-11-10 18:38:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483553002/20001
4 years, 1 month ago (2016-11-10 22:07:48 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 22:13:39 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:10:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd91e603433560ba111846de8ef7da52001a427a
Cr-Commit-Position: refs/heads/master@{#431374}

Powered by Google App Engine
This is Rietveld 408576698