Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chromecast/BUILD.gn

Issue 2483553002: Create cast_shell_lib target for cast_shell and browser tests. (Closed)
Patch Set: fixes android Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/BUILD.gn
diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn
index 5d49f2a1ba52923756820fdf130b143ccb2d43bc..e90b8927c504b6e69a21cf52c52d21c07d4c3bad 100644
--- a/chromecast/BUILD.gn
+++ b/chromecast/BUILD.gn
@@ -276,24 +276,17 @@ if (is_android) {
}
}
-source_set("cast_shell_common") {
+group("cast_shell_lib") {
deps = [
- ":cast_shell_pak",
- ":chromecast_locales_pak",
"//chromecast/app",
"//chromecast/browser",
"//chromecast/common",
- "//chromecast/common/media",
"//chromecast/renderer",
]
-}
-source_set("cast_shell_media") {
- deps = [
- "//chromecast/common/media",
- "//chromecast/media/service",
- "//chromecast/renderer/media",
- ]
+ if (chromecast_branding != "public") {
+ deps += [ "//chromecast/internal/shell" ]
+ }
}
executable("cast_shell") {
@@ -302,16 +295,13 @@ executable("cast_shell") {
]
deps = [
- ":cast_shell_common",
- ":cast_shell_media",
+ ":cast_shell_lib",
+ ":cast_shell_pak",
+ ":chromecast_locales_pak",
"//build/config/sanitizers:deps",
"//chromecast/app",
"//content/public/app:both",
]
-
- if (chromecast_branding != "public") {
- deps += [ "//chromecast/internal:cast_shell_internal" ]
- }
}
repack("cast_shell_pak") {
« no previous file with comments | « no previous file | chromecast/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698