chrome/browser/component_updater/sw_reporter_installer_win.cc - Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/component_updater/sw_reporter_installer_win.cc

diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc

index 5bd11650ce6241cfe54b3a4ddc7b268fb31beabd..fbec1455abdca8ea4065878038a74ecb71c41e41 100644

--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc

+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc

@@ -312,10 +312,10 @@

return false;

}

-update_client::CrxInstaller::Result SwReporterInstallerTraits::OnCustomInstall(

+bool SwReporterInstallerTraits::OnCustomInstall(

const base::DictionaryValue& manifest,

const base::FilePath& install_dir) {

- return update_client::CrxInstaller::Result(0);

+ return true;

}

void SwReporterInstallerTraits::ComponentReady(