Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2483333002: Allow data: SiteInstances in --isolate-sites-for-testing mode (Closed)

Created:
4 years, 1 month ago by ncarter (slow)
Modified:
4 years, 1 month ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow data: SiteInstances in --isolate-sites-for-testing mode Fixes several crashes in content_browsertests when run with that flag. BUG=663458 Committed: https://crrev.com/fd25e8398cf600c73594b88ca85676f44b207efa Cr-Commit-Position: refs/heads/master@{#430735}

Patch Set 1 #

Patch Set 2 : Remove dependent PS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ncarter (slow)
4 years, 1 month ago (2016-11-08 20:02:07 UTC) #2
Łukasz Anforowicz
Thanks for taking a look at this - LGTM.
4 years, 1 month ago (2016-11-08 20:05:31 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2483593002 Patch 40001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-08 20:08:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483333002/20001
4 years, 1 month ago (2016-11-08 21:22:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 22:19:00 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:24:26 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd25e8398cf600c73594b88ca85676f44b207efa
Cr-Commit-Position: refs/heads/master@{#430735}

Powered by Google App Engine
This is Rietveld 408576698