Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: content/shell/browser/shell_content_browser_client.cc

Issue 2483333002: Allow data: SiteInstances in --isolate-sites-for-testing mode (Closed)
Patch Set: Remove dependent PS Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_content_browser_client.cc
diff --git a/content/shell/browser/shell_content_browser_client.cc b/content/shell/browser/shell_content_browser_client.cc
index 6fa4cb14cf772bfc0fb2008d819ba0d78ce706d0..e5475cd511750421e9d97d0137a69a97c6b2a52f 100644
--- a/content/shell/browser/shell_content_browser_client.cc
+++ b/content/shell/browser/shell_content_browser_client.cc
@@ -154,12 +154,15 @@ bool ShellContentBrowserClient::DoesSiteRequireDedicatedProcess(
DCHECK(command_line->HasSwitch(switches::kIsolateSitesForTesting));
std::string pattern =
command_line->GetSwitchValueASCII(switches::kIsolateSitesForTesting);
+
url::Origin origin(effective_site_url);
- // Schemes like blob or filesystem, which have an embedded origin, should
- // already have been canonicalized to the origin site.
- CHECK_EQ(origin.scheme(), effective_site_url.scheme())
- << "a site url should have the same scheme as its origin.";
+ if (!origin.unique()) {
+ // Schemes like blob or filesystem, which have an embedded origin, should
+ // already have been canonicalized to the origin site.
+ CHECK_EQ(origin.scheme(), effective_site_url.scheme())
+ << "a site url should have the same scheme as its origin.";
+ }
// Practically |origin.Serialize()| is the same as
// |effective_site_url.spec()|, except Origin serialization strips the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698