Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 24833002: Add android_ninja, like android_make for ninja. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
scroggo, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add android_ninja, like android_make for ninja. android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run fine. They build so fast I thought maybe they were broken. Note that android_ninja with no argument is failing: ninja: Entering directory `out/config/android-arm_v7_thumb/Debug' ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it Will look into this. BUG= R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=11525 Committed: https://code.google.com/p/skia/source/detail?r=11527

Patch Set 1 #

Patch Set 2 : tweak comments #

Patch Set 3 : missing s #

Total comments: 4

Patch Set 4 : move make-android into android_make #

Patch Set 5 : move comment #

Patch Set 6 : bad diff #

Patch Set 7 : still bad #

Total comments: 4

Patch Set 8 : merge android_make and android_ninja #

Patch Set 9 : try again with restored SCRIPT_DIR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -40 lines) Patch
M platform_tools/android/bin/android_make View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -37 lines 0 comments Download
A platform_tools/android/bin/android_ninja View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
mtklein
7 years, 2 months ago (2013-09-26 21:14:32 UTC) #1
scroggo
https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja File platform_tools/android/bin/android_ninja (right): https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja#newcode4 platform_tools/android/bin/android_ninja:4: rm -f .android_config # If no -d flag is ...
7 years, 2 months ago (2013-09-26 21:23:24 UTC) #2
mtklein
https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja File platform_tools/android/bin/android_ninja (right): https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja#newcode4 platform_tools/android/bin/android_ninja:4: rm -f .android_config # If no -d flag is ...
7 years, 2 months ago (2013-09-26 21:39:54 UTC) #3
scroggo
On 2013/09/26 21:39:54, mtklein wrote: > https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja > File platform_tools/android/bin/android_ninja (right): > > https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja#newcode4 > ...
7 years, 2 months ago (2013-09-26 21:46:37 UTC) #4
mtklein
On 2013/09/26 21:46:37, scroggo wrote: > On 2013/09/26 21:39:54, mtklein wrote: > > > https://codereview.chromium.org/24833002/diff/5001/platform_tools/android/bin/android_ninja ...
7 years, 2 months ago (2013-09-27 13:55:55 UTC) #5
djsollen
I can see them now.
7 years, 2 months ago (2013-09-27 13:57:38 UTC) #6
djsollen
https://codereview.chromium.org/24833002/diff/35001/platform_tools/android/bin/android_ninja File platform_tools/android/bin/android_ninja (right): https://codereview.chromium.org/24833002/diff/35001/platform_tools/android/bin/android_ninja#newcode6 platform_tools/android/bin/android_ninja:6: echo $DEVICE_ID > .android_config seems like we could refactor ...
7 years, 2 months ago (2013-09-27 14:07:50 UTC) #7
mtklein
https://codereview.chromium.org/24833002/diff/35001/platform_tools/android/bin/android_ninja File platform_tools/android/bin/android_ninja (right): https://codereview.chromium.org/24833002/diff/35001/platform_tools/android/bin/android_ninja#newcode6 platform_tools/android/bin/android_ninja:6: echo $DEVICE_ID > .android_config On 2013/09/27 14:07:50, djsollen wrote: ...
7 years, 2 months ago (2013-09-30 15:41:58 UTC) #8
djsollen
lgtm
7 years, 2 months ago (2013-09-30 15:50:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/24833002/42001
7 years, 2 months ago (2013-09-30 17:00:06 UTC) #10
commit-bot: I haz the power
Failed to apply the patch. svn: Commit failed (details follow): svn: MKACTIVITY of '/svn/!svn/act/cadba964-0e45-4e71-9048-e2c565944b9c': authorization ...
7 years, 2 months ago (2013-09-30 17:10:06 UTC) #11
mtklein
Committed patchset #8 manually as r11525 (presubmit successful).
7 years, 2 months ago (2013-09-30 17:14:22 UTC) #12
mtklein
On 2013/09/30 17:14:22, mtklein wrote: > Committed patchset #8 manually as r11525 (presubmit successful). Going ...
7 years, 2 months ago (2013-09-30 17:31:38 UTC) #13
mtklein
7 years, 2 months ago (2013-09-30 17:32:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #9 manually as r11527 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698