platform_tools/android/bin/android_ninja - Issue 24833002: Add android_ninja, like android_make for ninja.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: platform_tools/android/bin/android_ninja

Issue 24833002: Add android_ninja, like android_make for ninja. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: still bad Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 #!/bin/bash

	2 set -e

	3

	4 rm -f .android_config # If no -d flag is given, force the default device (not the last one).

	5 source android_setup.sh

	6 echo $DEVICE_ID > .android_config
	djsollen 2013/09/27 14:07:50 seems like we could refactor android_make so that seems like we could refactor android_make so that we could share not only this logic, but the ccache logic as well. mtklein 2013/09/30 15:41:58 Yup. As we talked about before, all that ccache l Show quoted text On 2013/09/27 14:07:50, djsollen wrote: > seems like we could refactor android_make so that we could share not only this > logic, but the ccache logic as well. Yup. As we talked about before, all that ccache logic was dead code. I've refactored android_make to share as much logic as possible. android_ninja is just a symlink to android_make now.
	7

	8 exportVar GYP_GENERATORS ninja

	9 ./gyp_skia

	10

	11 OUT=$SKIA_OUT/${BUILDTYPE-Debug}
	djsollen 2013/09/27 14:07:50 The default string value is something I didn't kno The default string value is something I didn't know you could do, but it's just what we need. Can you just put a small comment there for us non-bash experts that buildtype defaults to debug if not defined. mtklein 2013/09/30 15:41:58 Yeah, it's handy. Done. Show quoted text On 2013/09/27 14:07:50, djsollen wrote: > The default string value is something I didn't know you could do, but it's just > what we need. Can you just put a small comment there for us non-bash experts > that buildtype defaults to debug if not defined. Yeah, it's handy. Done.
	12 ninja -C $OUT $APP_ARGS

	13 cd $OUT; ln -sf lib lib.target; cd - # android_run_skia looks in lib.target.

	14

OLD	NEW

« no previous file with comments | « platform_tools/android/bin/android_make ('k') | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »