Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2482973002: Rename CPDF_Linearized to CPDF_LinearizedHeader (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CPDF_Linearized to CPDF_LinearizedHeader My OCD insists that classes be named after nouns, and "linearized" feels like an adjective. Remove a redundant "if" while at it. Committed: https://pdfium.googlesource.com/pdfium/+/c09625ca59701fabeb49dc59edcf33031b2c6672

Patch Set 1 #

Patch Set 2 : Remove if #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -166 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D core/fpdfapi/parser/cpdf_linearized.h View 1 chunk +0 lines, -55 lines 0 comments Download
D core/fpdfapi/parser/cpdf_linearized.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
A + core/fpdfapi/parser/cpdf_linearized_header.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + core/fpdfapi/parser/cpdf_linearized_header.cpp View 1 4 chunks +6 lines, -8 lines 1 comment Download
M core/fpdfapi/parser/cpdf_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/libfuzzer/pdf_hint_table_fuzzer.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 17 (7 generated)
Tom Sepez
Dan, for review, no functional change.
4 years, 1 month ago (2016-11-07 19:13:31 UTC) #4
dsinclair
lgtm
4 years, 1 month ago (2016-11-07 19:25:53 UTC) #5
Tom Sepez
On 2016/11/07 19:25:53, dsinclair wrote: > lgtm And I lied. Just had to make one ...
4 years, 1 month ago (2016-11-07 19:27:21 UTC) #6
Tom Sepez
https://codereview.chromium.org/2482973002/diff/20001/core/fpdfapi/parser/cpdf_linearized_header.cpp File core/fpdfapi/parser/cpdf_linearized_header.cpp (left): https://codereview.chromium.org/2482973002/diff/20001/core/fpdfapi/parser/cpdf_linearized_header.cpp#oldcode50 core/fpdfapi/parser/cpdf_linearized_header.cpp:50: if (!pDict) Can't happen given check above and this ...
4 years, 1 month ago (2016-11-07 19:27:49 UTC) #7
dsinclair
lgtm
4 years, 1 month ago (2016-11-07 19:31:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482973002/20001
4 years, 1 month ago (2016-11-07 19:31:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/c09625ca59701fabeb49dc59edcf33031b2c6672
4 years, 1 month ago (2016-11-07 19:46:15 UTC) #13
Lei Zhang
Forgot the fuzzers, forgot the fuzzers, forgot the fuzzers!
4 years, 1 month ago (2016-11-07 23:30:06 UTC) #15
Lei Zhang
https://codereview.chromium.org/2482973002/diff/20001/testing/libfuzzer/pdf_hint_table_fuzzer.cc File testing/libfuzzer/pdf_hint_table_fuzzer.cc (right): https://codereview.chromium.org/2482973002/diff/20001/testing/libfuzzer/pdf_hint_table_fuzzer.cc#newcode10 testing/libfuzzer/pdf_hint_table_fuzzer.cc:10: #include "core/fpdfapi/parser/cpdf_linearized.h" Actually, just this.
4 years, 1 month ago (2016-11-07 23:31:05 UTC) #16
Lei Zhang
4 years, 1 month ago (2016-11-07 23:35:51 UTC) #17
Message was sent while issue was closed. 
On 2016/11/07 23:31:05, Lei Zhang wrote:
>
https://codereview.chromium.org/2482973002/diff/20001/testing/libfuzzer/pdf_h...
> File testing/libfuzzer/pdf_hint_table_fuzzer.cc (right):
> 
>
https://codereview.chromium.org/2482973002/diff/20001/testing/libfuzzer/pdf_h...
> testing/libfuzzer/pdf_hint_table_fuzzer.cc:10: #include
> "core/fpdfapi/parser/cpdf_linearized.h"
> Actually, just this.

https://codereview.chromium.org/2477323004

Powered by Google App Engine
This is Rietveld 408576698