Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: core/fpdfapi/parser/cpdf_linearized_header.cpp

Issue 2482973002: Rename CPDF_Linearized to CPDF_LinearizedHeader (Closed)
Patch Set: Remove if Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/parser/cpdf_linearized_header.cpp
diff --git a/core/fpdfapi/parser/cpdf_linearized.cpp b/core/fpdfapi/parser/cpdf_linearized_header.cpp
similarity index 86%
rename from core/fpdfapi/parser/cpdf_linearized.cpp
rename to core/fpdfapi/parser/cpdf_linearized_header.cpp
index ec57f100cbebb3e329e55a81f3cd9ffa1acdf7ac..9ecc051f8ab6b482289a864d1435f0f0369012e6 100644
--- a/core/fpdfapi/parser/cpdf_linearized.cpp
+++ b/core/fpdfapi/parser/cpdf_linearized_header.cpp
@@ -4,7 +4,7 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#include "core/fpdfapi/parser/cpdf_linearized.h"
+#include "core/fpdfapi/parser/cpdf_linearized_header.h"
#include "core/fpdfapi/parser/cpdf_array.h"
#include "core/fpdfapi/parser/cpdf_dictionary.h"
@@ -32,7 +32,7 @@ bool IsValidNumericDictionaryValue(const CPDF_Dictionary* pDict,
} // namespace
// static
-std::unique_ptr<CPDF_Linearized> CPDF_Linearized::CreateForObject(
+std::unique_ptr<CPDF_LinearizedHeader> CPDF_LinearizedHeader::CreateForObject(
std::unique_ptr<CPDF_Object> pObj) {
auto pDict = ToDictionary(std::move(pObj));
if (!pDict || !pDict->KeyExist("Linearized") ||
@@ -43,12 +43,10 @@ std::unique_ptr<CPDF_Linearized> CPDF_Linearized::CreateForObject(
!IsValidNumericDictionaryValue<FX_FILESIZE>(pDict.get(), "E", 1) ||
!IsValidNumericDictionaryValue<uint32_t>(pDict.get(), "O", 1))
return nullptr;
- return pdfium::WrapUnique(new CPDF_Linearized(pDict.get()));
+ return pdfium::WrapUnique(new CPDF_LinearizedHeader(pDict.get()));
}
-CPDF_Linearized::CPDF_Linearized(const CPDF_Dictionary* pDict) {
- if (!pDict)
Tom Sepez 2016/11/07 19:27:49 Can't happen given check above and this is now pro
- return;
+CPDF_LinearizedHeader::CPDF_LinearizedHeader(const CPDF_Dictionary* pDict) {
m_szFileSize = pDict->GetIntegerFor("L");
m_dwFirstPageNo = pDict->GetIntegerFor("P");
m_szLastXRefOffset = pDict->GetIntegerFor("T");
@@ -64,8 +62,8 @@ CPDF_Linearized::CPDF_Linearized(const CPDF_Dictionary* pDict) {
}
}
-CPDF_Linearized::~CPDF_Linearized() {}
+CPDF_LinearizedHeader::~CPDF_LinearizedHeader() {}
-bool CPDF_Linearized::HasHintTable() const {
+bool CPDF_LinearizedHeader::HasHintTable() const {
return GetPageCount() > 1 && GetHintStart() > 0 && GetHintLength() > 0;
}

Powered by Google App Engine
This is Rietveld 408576698